public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] remove duplicate includes (fwd)
Date: Fri, 29 Oct 2004 18:26:12 -0400	[thread overview]
Message-ID: <20041029222612.GI23841@redhat.com> (raw)
In-Reply-To: <20041029214717.GW6677@stusta.de>

On Fri, Oct 29, 2004 at 11:47:17PM +0200, Adrian Bunk wrote:

 > --- linux-2.6.9-mm1-full/drivers/cpufreq/cpufreq_ondemand.c.old	2004-10-22 21:37:33.000000000 +0200
 > +++ linux-2.6.9-mm1-full/drivers/cpufreq/cpufreq_ondemand.c	2004-10-22 21:52:35.000000000 +0200
 > @@ -26,7 +26,6 @@
 >  #include <linux/kmod.h>
 >  #include <linux/workqueue.h>
 >  #include <linux/jiffies.h>
 > -#include <linux/config.h>
 >  #include <linux/kernel_stat.h>
 >  #include <linux/percpu.h>

Not only was this duplicated, but its also unnecessary as
there are no CONFIG_ options in that file.
You may want to add that checking to your script too.

I've killed them both in cpufreq-bk

thanks,

		Dave



  reply	other threads:[~2004-10-29 22:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29 21:47 [2.6 patch] remove duplicate includes (fwd) Adrian Bunk
2004-10-29 22:26 ` Dave Jones [this message]
2004-10-29 22:37   ` Randy.Dunlap
2004-10-31  9:36 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041029222612.GI23841@redhat.com \
    --to=davej@redhat.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox