* RFC: [2.6 patch] Eicon: disable debuglib for modules
@ 2004-10-30 7:22 Adrian Bunk
2004-10-30 11:48 ` Armin Schindler
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2004-10-30 7:22 UTC (permalink / raw)
To: mac; +Cc: isdn4linux, linux-kernel
Is there a good reason why debuglib is enabled for modules?
If not, I'd propose the patch below to disable it.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h.old 2004-10-30 08:39:51.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h 2004-10-30 08:40:28.000000000 +0200
@@ -35,10 +35,8 @@
#include "cardtype.h"
-/* activate debuglib for modules only */
-#ifndef MODULE
+/* disable debuglib */
#define DIVA_NO_DEBUGLIB
-#endif
#define DIVA_INIT_FUNCTION __init
#define DIVA_EXIT_FUNCTION __exit
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: RFC: [2.6 patch] Eicon: disable debuglib for modules
2004-10-30 7:22 RFC: [2.6 patch] Eicon: disable debuglib for modules Adrian Bunk
@ 2004-10-30 11:48 ` Armin Schindler
2004-12-20 0:22 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Armin Schindler @ 2004-10-30 11:48 UTC (permalink / raw)
To: Adrian Bunk; +Cc: isdn4linux, Linux Kernel Mailinglist, developers
On Sat, 30 Oct 2004, Adrian Bunk wrote:
> Is there a good reason why debuglib is enabled for modules?
Yes.
Without it, there would be no possibility to use the maintainance module
to debug the isdn/card/capi interaction.
> If not, I'd propose the patch below to disable it.
I have to disagree. This patch would disable a major feature of the
diva driver collection.
Armin
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h.old 2004-10-30 08:39:51.000000000 +0200
> +++ linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h 2004-10-30 08:40:28.000000000 +0200
> @@ -35,10 +35,8 @@
>
> #include "cardtype.h"
>
> -/* activate debuglib for modules only */
> -#ifndef MODULE
> +/* disable debuglib */
> #define DIVA_NO_DEBUGLIB
> -#endif
>
> #define DIVA_INIT_FUNCTION __init
> #define DIVA_EXIT_FUNCTION __exit
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: RFC: [2.6 patch] Eicon: disable debuglib for modules
2004-10-30 11:48 ` Armin Schindler
@ 2004-12-20 0:22 ` Adrian Bunk
2004-12-20 6:41 ` Armin Schindler
2005-02-09 13:55 ` Armin Schindler
0 siblings, 2 replies; 5+ messages in thread
From: Adrian Bunk @ 2004-12-20 0:22 UTC (permalink / raw)
To: Armin Schindler; +Cc: isdn4linux, Linux Kernel Mailinglist, developers
> > Is there a good reason why debuglib is enabled for modules?
>
> Yes.
> Without it, there would be no possibility to use the maintainance module
> to debug the isdn/card/capi interaction.
>
> > If not, I'd propose the patch below to disable it.
>
> I have to disagree. This patch would disable a major feature of the
> diva driver collection.
How do I enable this maintainance module in the kernel?
> Armin
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: RFC: [2.6 patch] Eicon: disable debuglib for modules
2004-12-20 0:22 ` Adrian Bunk
@ 2004-12-20 6:41 ` Armin Schindler
2005-02-09 13:55 ` Armin Schindler
1 sibling, 0 replies; 5+ messages in thread
From: Armin Schindler @ 2004-12-20 6:41 UTC (permalink / raw)
To: Adrian Bunk; +Cc: isdn4linux, Linux Kernel Mailinglist, developers
On Mon, 20 Dec 2004, Adrian Bunk wrote:
> > > Is there a good reason why debuglib is enabled for modules?
> >
> > Yes.
> > Without it, there would be no possibility to use the maintainance module
> > to debug the isdn/card/capi interaction.
> >
> > > If not, I'd propose the patch below to disable it.
> >
> > I have to disagree. This patch would disable a major feature of the
> > diva driver collection.
>
> How do I enable this maintainance module in the kernel?
The option 'DIVA Maint driver support' enables this module.
When the module is loaded, all diva modules provide trace logs to that
module. Using the user-space utility 'divactrl' you can set e.g. trace masks
and read the messages.
Armin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: RFC: [2.6 patch] Eicon: disable debuglib for modules
2004-12-20 0:22 ` Adrian Bunk
2004-12-20 6:41 ` Armin Schindler
@ 2005-02-09 13:55 ` Armin Schindler
1 sibling, 0 replies; 5+ messages in thread
From: Armin Schindler @ 2005-02-09 13:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: developers, isdn4linux, Linux Kernel Mailinglist
On Mon, 20 Dec 2004, Adrian Bunk wrote:
> > > Is there a good reason why debuglib is enabled for modules?
> >
> > Yes.
> > Without it, there would be no possibility to use the maintainance module
> > to debug the isdn/card/capi interaction.
> >
> > > If not, I'd propose the patch below to disable it.
> >
> > I have to disagree. This patch would disable a major feature of the
> > diva driver collection.
>
> How do I enable this maintainance module in the kernel?
In the 'ISDN active card' 'Eicon' section you will find the option
DIVA Maint driver support
which is only available as a module.
When the other diva drivers are compiled as modules too, they will provide
all trace data to the maint module.
The userspace tool 'divactrl' then retrieves the trace data according to
set trace masks.
Armin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-02-09 13:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-30 7:22 RFC: [2.6 patch] Eicon: disable debuglib for modules Adrian Bunk
2004-10-30 11:48 ` Armin Schindler
2004-12-20 0:22 ` Adrian Bunk
2004-12-20 6:41 ` Armin Schindler
2005-02-09 13:55 ` Armin Schindler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox