From: Vojtech Pavlik <vojtech@suse.cz>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Sami Farin <7atbggg02@sneakemail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Linux 2.6.9-ac5 - more stupid FAT filesystems
Date: Sat, 30 Oct 2004 13:04:15 +0200 [thread overview]
Message-ID: <20041030110414.GA3130@ucw.cz> (raw)
In-Reply-To: <20041030090308.GA6060@m.safari.iki.fi>
On Sat, Oct 30, 2004 at 12:03:08PM +0300, Sami Farin wrote:
> On Fri, Oct 29, 2004 at 03:40:32PM +0100, Alan Cox wrote:
> > This update adds some of the more minor fixes as well as a fix
> > for a nasty __init bug. Nothing terribly pressing for non-S390 users
> > unless they are hitting one of the bugs described or need the new
> > driver bits.
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/alan/linux-2.6/2.6.9/
> >
> > 2.6.9-ac5
> > o Fix oops in and enable IT8212 driver (me)
> > o Minor delkin driver fix (Mark Lord)
> > o Fix NFS mount hangs with long FQDN (Jan Kasprzak)
> > | I've used this version as its clearly correct for 2.6.9
> > | although it might not be the right future solution
> > o Fix overstrict FAT checks stopping reading of (Vojtech Pavlik)
> > some devices like Nokia phones
>
> I guess Canon IXUS 400 is overstupid or something.
No, the patch from me (included in -ac) is completely bogus. The correct
patch is attached.
diff -urN linux-2.6.8/fs/fat/inode.c linux-2.6.8-fat/fs/fat/inode.c
--- linux-2.6.8/fs/fat/inode.c 2004-09-30 15:27:58.343661051 +0200
+++ linux-2.6.8-fat/fs/fat/inode.c 2004-09-30 15:33:32.820915377 +0200
@@ -1003,6 +1003,8 @@
/* all is as it should be */
} else if (media == 0xf8 && FAT_FIRST_ENT(sb, 0xfe) == first) {
/* bad, reported on pc9800 */
+ } else if (media == 0xf8 && FAT_FIRST_ENT(sb, 0xff) == first) {
+ /* bad, reported on Nokia phone with USB storage */
} else if (media == 0xf0 && FAT_FIRST_ENT(sb, 0xf8) == first) {
/* bad, reported with a MO disk on win95/me */
} else if (first == 0) {
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-10-30 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 14:40 Linux 2.6.9-ac5 Alan Cox
2004-10-30 4:47 ` Nuno Silva
2004-10-30 11:20 ` Greg Louis
2004-10-30 9:03 ` Linux 2.6.9-ac5 - more stupid FAT filesystems Sami Farin
2004-10-30 11:04 ` Vojtech Pavlik [this message]
2004-10-30 11:20 ` Sami Farin
2004-10-30 22:32 ` Alan Cox
2004-10-31 13:15 ` Linux 2.6.9-ac5 Sami Farin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041030110414.GA3130@ucw.cz \
--to=vojtech@suse.cz \
--cc=7atbggg02@sneakemail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox