From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alex Williamson <alex.williamson@hp.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] set membase in serial8250_request_port
Date: Sat, 30 Oct 2004 11:28:18 +0100 [thread overview]
Message-ID: <20041030112818.C11909@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1098991495.2719.8.camel@tdi>; from alex.williamson@hp.com on Thu, Oct 28, 2004 at 01:24:55PM -0600
On Thu, Oct 28, 2004 at 01:24:55PM -0600, Alex Williamson wrote:
> The iounmap/ioremap path in serial8250_release/request_port is
> terribly unbalanced. The UPF_IOREMAP flag is used to determine if a
> port gets ioremap'd, but plays no part in whether it gets iounmap'd.
> It's easy to see how an MMIO serial port can be passed through
> uart_set_info and end up with an unmapped membase. The results is a
> non-functional UART or worse. I've tried to generate some discussion on
> the proper fix for this, but I haven't succeeded. I propose the patch
> below as a safe compromise. An MMIO uart w/ a mapbase, but no membase
> doesn't seem viable to me. Thanks,
I'm going to be doing a major update to serial today, and these patches
are made rather unnecessary by that. Thanks for pointing out the problem
anyway.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2004-10-30 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 18:54 [PATCH] set membase in serial8250_request_port Alex Williamson
2004-10-04 21:04 ` Russell King
2004-10-04 21:43 ` Alex Williamson
2004-10-18 14:56 ` Alex Williamson
2004-10-28 19:24 ` Alex Williamson
2004-10-30 10:28 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041030112818.C11909@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=alex.williamson@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox