From: Adrian Bunk <bunk@stusta.de>
To: Anders Larsen <al@alarsen.net>
Cc: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] mark QNX4FS_RW as BROKEN
Date: Sat, 30 Oct 2004 23:22:50 +0200 [thread overview]
Message-ID: <20041030212249.GY4374@stusta.de> (raw)
In-Reply-To: <1099162888l.2673l.0l@errol.alarsen.net>
On Sat, Oct 30, 2004 at 07:01:28PM +0000, Anders Larsen wrote:
> On Sat, Oct 30, 2004 at 08:07:02PM +0200, Adrian Bunk wrote:
> >The patch below does the following cleanups in the QNX4 fs:
> >- remove two unused global functions
>
> If you remove any code inside the #ifdef CONFIG_QNX4FS_RW we might
> as well remove the option "config QNX4FS_RW" altogether.
> It's horribly broken, and I don't intend to fix it; while I was
> thinking about how to properly implement write-support, somebody else
> went away and did it. As that alternative seems to work well and is
> being actively maintained, I won't try to reinvent it.
OK, I understand why my patch wasn't good.
What about the following to mark it as BROKEN in the Kconfig file?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm2-full/fs/Kconfig.old 2004-10-30 23:15:17.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/fs/Kconfig 2004-10-30 23:15:34.000000000 +0200
@@ -1353,7 +1353,7 @@
config QNX4FS_RW
bool "QNX4FS write support (DANGEROUS)"
- depends on QNX4FS_FS && EXPERIMENTAL
+ depends on QNX4FS_FS && EXPERIMENTAL && BROKEN
help
Say Y if you want to test write support for QNX4 file systems.
next prev parent reply other threads:[~2004-10-30 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 18:07 [2.6 patch] QNX4 cleanups Adrian Bunk
2004-10-30 18:34 ` Al Viro
2004-10-30 19:01 ` Anders Larsen
2004-10-30 21:22 ` Adrian Bunk [this message]
2004-10-30 21:55 ` [2.6 patch] mark QNX4FS_RW as BROKEN Anders Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041030212249.GY4374@stusta.de \
--to=bunk@stusta.de \
--cc=al@alarsen.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox