From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261351AbUJ3WWX (ORCPT ); Sat, 30 Oct 2004 18:22:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261359AbUJ3WWX (ORCPT ); Sat, 30 Oct 2004 18:22:23 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:15364 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S261351AbUJ3WWT (ORCPT ); Sat, 30 Oct 2004 18:22:19 -0400 Date: Sat, 30 Oct 2004 23:22:05 +0100 From: Russell King To: Adrian Bunk Cc: Roman Zippel , Sam Ravnborg , linux-kernel@vger.kernel.org, greg@kroah.com Subject: Re: [2.6 patch] let FW_LOADER select HOTPLUG Message-ID: <20041030232204.F15392@flint.arm.linux.org.uk> Mail-Followup-To: Adrian Bunk , Roman Zippel , Sam Ravnborg , linux-kernel@vger.kernel.org, greg@kroah.com References: <20041030220309.GE4374@stusta.de> <20041030231156.E15392@flint.arm.linux.org.uk> <20041030221841.GG4374@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20041030221841.GG4374@stusta.de>; from bunk@stusta.de on Sun, Oct 31, 2004 at 12:18:41AM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 31, 2004 at 12:18:41AM +0200, Adrian Bunk wrote: > On Sat, Oct 30, 2004 at 11:11:56PM +0100, Russell King wrote: > > On Sun, Oct 31, 2004 at 12:03:09AM +0200, Adrian Bunk wrote: > > > > > > If it wasn't for external modules, FW_LOADER wasn't user-visible. > > > Let FW_LOADER select HOTPLUG To make the dependencies easier for users. > > > > You know what I'm going to say about this patch, so I'll won't repeat, > > except to say it has to do with select on user visible symbols. > > I can send a patch that changes all dependencies on HOTPLUG to selects. > Would thids be acceptable? Yup, especially as you can use the same argument as the FW_LOADER case applies to the PCMCIA case, or PCI hotplug case. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core