From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: geert@linux-m68k.org, torvalds@osdl.org,
linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [PATCH 475] HP300 LANCE
Date: Sun, 31 Oct 2004 02:48:40 -0800 [thread overview]
Message-ID: <20041031024840.6eeee92d.akpm@osdl.org> (raw)
In-Reply-To: <4184C16E.80705@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Andrew Morton wrote:
> > Jeff Garzik <jgarzik@pobox.com> wrote:
> >
> >>content looks OK, but patch appears to be whitespace-challenged...
> >>
> >
> >
> > It applies successfully.
>
> I'm talking about the _other_ type of "whitespace challenged", such as,
>
> - volatile struct lance_regs *ll;
> + unsigned long base;
>
> and
>
> - void *va = dio_scodetoviraddr(scode);
> + unsigned long pa = dio_scodetophysaddr(scode);
> + unsigned long va = (pa + DIO_VIRADDRBASE);
>
> Reading through the patch you can see other one-space-off spots.
>
That's because the stoopid driver is using spaces instead of tabs all over
the place. It comes out visually OK once the patch is applied. But it's a
useful reminder of how much dreck we have in the tree.
next prev parent reply other threads:[~2004-10-31 11:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-31 10:03 [PATCH 475] HP300 LANCE Geert Uytterhoeven
2004-10-31 10:14 ` Jeff Garzik
2004-10-31 10:19 ` Andrew Morton
2004-10-31 10:41 ` Jeff Garzik
2004-10-31 10:48 ` Andrew Morton [this message]
2004-10-31 10:57 ` Jeff Garzik
2004-10-31 11:09 ` Andrew Morton
2004-10-31 11:44 ` Geert Uytterhoeven
2004-10-31 11:50 ` Herbert Xu
2004-10-31 11:58 ` Jeff Garzik
2004-11-01 14:22 ` Christoph Hellwig
2004-11-16 8:43 ` Christoph Hellwig
2004-11-17 7:12 ` Andrew Morton
2004-11-21 10:01 ` Geert Uytterhoeven
2004-11-21 11:19 ` Kars de Jong
2004-11-22 0:12 ` Andrew Morton
2004-11-22 0:25 ` Sohail Somani
2004-11-22 10:54 ` Geert Uytterhoeven
2004-11-22 8:26 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2004-11-01 3:46 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041031024840.6eeee92d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=geert@linux-m68k.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox