public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Roland Dreier <roland@topspin.com>,
	sam@ravnborg.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/take 2] ppc: fix build with O=$(output_dir)
Date: Sun, 31 Oct 2004 23:39:50 +0100	[thread overview]
Message-ID: <20041031223949.GB21471@mars.ravnborg.org> (raw)
In-Reply-To: <20041019182928.GA12544@smtp.west.cox.net>

On Tue, Oct 19, 2004 at 11:29:28AM -0700, Tom Rini wrote:
 
> This misses the bit to invoke the checker as well (when I first thought
> this up I poked Al Viro about the general question of checker on boot
> code, and he wanted it, so...).  And having 2 'magic' rules not just 1
> is why I don't like this too much and was hoping Sam would have some
> idea of a good fix.

Hi Tom.

Finally took a look.
The best approach is to grab a copy of the .c file and compile
that in this dir.
In this way we avoid unessesary recompile etc. but waste a bit disk space.
I do not like symlinks in general and made a copy. (note: uses cat to give
appropriate permission)

If you are OK with this let me know if you want me to push it to linus
or you go via the ppc tree.

PS: Had troubles with kbd so commented out.

	Sam

===== Makefile 1.11 vs edited =====
--- 1.11/arch/ppc/boot/lib/Makefile	2004-10-25 21:47:48 +02:00
+++ edited/Makefile	2004-10-31 23:37:23 +01:00
@@ -2,9 +2,22 @@
 # Makefile for some libs needed by zImage.
 #
 
-CFLAGS_kbd.o	+= -Idrivers/char
+CFLAGS_kbd.o	:= -Idrivers/char
+CFLAGS_vreset.o := -I$(srctree)/arch/ppc/boot/include
 
-lib-y := $(addprefix ../../../../lib/zlib_inflate/, \
-           infblock.o infcodes.o inffast.o inflate.o inftrees.o infutil.o)
-lib-y += div64.o
-lib-$(CONFIG_VGA_CONSOLE) += vreset.o kbd.o
+zlib  := infblock.c infcodes.c inffast.c inflate.c inftrees.c infutil.c
+	 
+lib-y += $(zlib:.c=.o) div64.o
+lib-$(CONFIG_VGA_CONSOLE) += vreset.o #kbd.o
+
+
+# zlib files needs header from their original place
+EXTRA_CFLAGS += -Ilib/zlib_inflate
+
+quiet_cmd_copy_zlib = COPY    $@
+      cmd_copy_zlib = cat $< > $@
+
+$(addprefix $(obj)/,$(zlib)): $(obj)/%: $(srctree)/lib/zlib_inflate/%
+	$(call cmd,copy_zlib)
+
+clean-files := $(zlib)

  parent reply	other threads:[~2004-10-31 21:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-19  6:48 [PATCH] ppc: fix build with O=$(output_dir) Roland Dreier
2004-10-19 16:44 ` Tom Rini
2004-10-19 18:14   ` [PATCH/take 2] " Roland Dreier
2004-10-19 18:29     ` Tom Rini
2004-10-19 18:58       ` Roland Dreier
2004-10-26 22:33         ` Sam Ravnborg
2004-10-31 22:39       ` Sam Ravnborg [this message]
2004-10-31 21:53         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041031223949.GB21471@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@topspin.com \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox