From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH 475] HP300 LANCE
Date: Sun, 31 Oct 2004 22:46:19 -0500 [thread overview]
Message-ID: <200410312250_MC3-1-8DAC-4170@compuserve.com> (raw)
On Sun, 31 Oct 2004 at 02:48:40 -0800 Andrew Morton <akpm@osdl.org> wrote:
> It comes out visually OK once the patch is applied. But it's a
> useful reminder of how much dreck we have in the tree.
That's for sure:
[me@nb linux-2.6.9]$ find . -name "*.[ch]" | xargs egrep -H -n '^[[:space:]]+if\(' | \
> tee if_should_be_followed_by_space | wc -l
18991
And my favorite pet peeve:
[me@nb linux-2.6.9]$ find . -name "*.[ch]" | \
> xargs egrep -H -n '^[[:space:]]+return[[:space:]]*\([^)]+\);' | \
> tee return_is_not_a_function | wc -l
9867
There are a lot more than that but I could find no obvious way of including
"return(parenthesized expr)" while excluding "return (typecast)(expr)".
--Chuck Ebbert 31-Oct-04 23:46:37
next reply other threads:[~2004-11-01 3:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-01 3:46 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-31 10:03 [PATCH 475] HP300 LANCE Geert Uytterhoeven
2004-10-31 10:14 ` Jeff Garzik
2004-10-31 10:19 ` Andrew Morton
2004-10-31 10:41 ` Jeff Garzik
2004-10-31 10:48 ` Andrew Morton
2004-10-31 10:57 ` Jeff Garzik
2004-10-31 11:09 ` Andrew Morton
2004-10-31 11:44 ` Geert Uytterhoeven
2004-10-31 11:50 ` Herbert Xu
2004-10-31 11:58 ` Jeff Garzik
2004-11-01 14:22 ` Christoph Hellwig
2004-11-16 8:43 ` Christoph Hellwig
2004-11-17 7:12 ` Andrew Morton
2004-11-21 10:01 ` Geert Uytterhoeven
2004-11-21 11:19 ` Kars de Jong
2004-11-22 0:12 ` Andrew Morton
2004-11-22 0:25 ` Sohail Somani
2004-11-22 10:54 ` Geert Uytterhoeven
2004-11-22 8:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410312250_MC3-1-8DAC-4170@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox