From: Adrian Bunk <bunk@stusta.de>
To: Ben Collins <bcollins@debian.org>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: RFC: [2.6 patch] ieee1394 cleanup
Date: Mon, 1 Nov 2004 00:29:54 +0100 [thread overview]
Message-ID: <20041031232954.GG2495@stusta.de> (raw)
In-Reply-To: <20041031212858.GC9684@phunnypharm.org>
On Sun, Oct 31, 2004 at 04:28:58PM -0500, Ben Collins wrote:
> Need to leave the csr1212 files alone. csr1212.[ch] is used for userspace
> and kernelspace, and I don't want to have two versions.
But in this case, these functions don't have to be EXPORT_SYMBOL'ed?
And besides this, they are global functions meaning that although they
are never used inside the kernel, they need space for every user of
FireWire.
What about wrapping them inside #ifndef __KERNEL__ ?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-10-31 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-31 21:32 RFC: [2.6 patch] ieee1394 cleanup Adrian Bunk
2004-10-31 21:28 ` Ben Collins
2004-10-31 23:29 ` Adrian Bunk [this message]
2004-10-31 22:04 ` Ben Collins
2004-11-01 13:58 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041031232954.GG2495@stusta.de \
--to=bunk@stusta.de \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox