public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: linux-kernel@vger.kernel.org
Subject: x86_64 expertise needed re: BUG() at pageattr:107
Date: Mon, 1 Nov 2004 15:59:21 -0500	[thread overview]
Message-ID: <20041101155921.C30292@tuxdriver.com> (raw)

The x86_64 version of pageattr.c contains the following definition
of revert_page():

static void revert_page(unsigned long address, pgprot_t ref_prot)
{
       pgd_t *pgd;
       pmd_t *pmd;
       pte_t large_pte;

       pgd = pgd_offset_k(address);
       pmd = pmd_offset(pgd, address);
       BUG_ON(pmd_val(*pmd) & _PAGE_PSE);
       pgprot_val(ref_prot) |= _PAGE_PSE;
       large_pte = mk_pte_phys(__pa(address) & LARGE_PAGE_MASK, ref_prot);
       set_pte((pte_t *)pmd, large_pte);
}

Please notice the BUG_ON() (originally at line pageattr.c:107).
I notice that the x86 version of revert_page() has no similar check.

Would someone please explain:

	a) why is this a bug?;
	b) what is likely to have triggered it?; and,
	c) why is x86_64 different from x86?

I've Googled a few references to this problem (latest 10/10/2004),
but I've seen no solutions.  I do not currently have a reproducible
test case, although I have a report (which dates from around 2.6.7)
of seeing this problem when installing the e1000 driver module.

I'd be happy to see some educated guesses... :-)

Thanks for any input!

John
-- 
John W. Linville
linville@tuxdriver.com

             reply	other threads:[~2004-11-01 22:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-01 20:59 John W. Linville [this message]
2004-11-02 19:02 ` x86_64 expertise needed re: BUG() at pageattr:107 Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041101155921.C30292@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox