From: Jens Axboe <axboe@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] bio.c: make bio_destructor static
Date: Mon, 1 Nov 2004 19:03:48 +0100 [thread overview]
Message-ID: <20041101180348.GB5299@suse.de> (raw)
In-Reply-To: <20041030164450.GN4374@stusta.de>
On Sat, Oct 30 2004, Adrian Bunk wrote:
>
> bio_destructor in fs/bio.c isn't used outside of this file, and after
> quickly thinking about it I didn't find a reason why it should.
>
> The patch below makes it static.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Jens Axboe <axboe@suse.de>
> --- linux-2.6.10-rc1-mm2-full/fs/bio.c.old 2004-10-30 13:53:41.000000000 +0200
> +++ linux-2.6.10-rc1-mm2-full/fs/bio.c 2004-10-30 13:56:16.000000000 +0200
> @@ -91,7 +91,7 @@
> /*
> * default destructor for a bio allocated with bio_alloc()
> */
> -void bio_destructor(struct bio *bio)
> +static void bio_destructor(struct bio *bio)
> {
> const int pool_idx = BIO_POOL_IDX(bio);
> struct biovec_pool *bp = bvec_array + pool_idx;
>
>
--
Jens Axboe
next prev parent reply other threads:[~2004-11-01 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 16:44 [2.6 patch] bio.c: make bio_destructor static Adrian Bunk
2004-11-01 18:03 ` Jens Axboe [this message]
2004-11-01 18:51 ` Jeff V. Merkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041101180348.GB5299@suse.de \
--to=axboe@suse.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox