public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] add requeue task
Date: Tue, 2 Nov 2004 13:58:34 +0100	[thread overview]
Message-ID: <20041102125834.GI15290@elte.hu> (raw)
In-Reply-To: <41878318.8020801@kolivas.org>


* Con Kolivas <kernel@kolivas.org> wrote:

> >| Change the granularity code to requeue tasks at their best priority
> >| instead of changing priority while they're running. This keeps tasks 
> >| at their top interactive level during their whole timeslice.
> >
> >this is a behavioral change and should go into the 'possible negative
> >effect on interactivity' bucket. (of course it could very likely have a
> >positive effect as well - the bucket is just to separate the risks.)
> 
> Actually I'd like to say I did it for positive effect to counter the
> change that occurred with dropping interactive credit. That was what I
> found in my testing, and I'd like them both to go together into -mm.

just in case my splitout comment wasnt clear: ack for that fix too,
conditional on good -mm exposure. Unlike the interactive_credit change i
think this one would be borderline doable for 2.6.10 if in -mm for a
couple of weeks at least, because the regression fixed by this is fresh
in 2.6.9.

	Ingo

  reply	other threads:[~2004-11-02 13:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-02  4:07 [PATCH] add requeue task Con Kolivas
2004-11-02 12:35 ` Nick Piggin
2004-11-02 15:16   ` Nikita Danilov
2004-11-02 22:07     ` Nick Piggin
2004-11-03  8:12     ` Con Kolivas
2004-11-02 12:42 ` Ingo Molnar
2004-11-02 12:52   ` Con Kolivas
2004-11-02 12:58     ` Ingo Molnar [this message]
2004-11-02 14:02       ` [PATCH] requeue at granularity intervals Con Kolivas
2004-11-02 14:00   ` [PATCH] add requeue task redo Con Kolivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041102125834.GI15290@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox