public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Jan Kasprzak <kas@fi.muni.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Minor fix of RCU documentation
Date: Wed, 3 Nov 2004 10:59:55 -0800	[thread overview]
Message-ID: <20041103185954.GA1331@us.ibm.com> (raw)
In-Reply-To: <20041102232317.GD13012@fi.muni.cz>

Good catch!  Andrew, please apply.

						Thanx, Paul

Acked-by: <paulmck@us.ibm.com>

On Wed, Nov 03, 2004 at 12:23:18AM +0100, Jan Kasprzak wrote:
> 	Hello, all!
> 
> the attached patch fixes an incorrect example in Documentation/RCU/listRCU.txt
> - the "original" lock-based code should not call RCU functions, of course.
> 
> -Yenya
> 
> Signed-Off-By: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
> 
> --- linux-2.6.9/Documentation/RCU/listRCU.txt.orig	2004-10-18 23:53:44.000000000 +0200
> +++ linux-2.6.9/Documentation/RCU/listRCU.txt	2004-10-30 14:49:42.706526360 +0200
> @@ -82,7 +82,7 @@
>  		list_for_each_entry(e, list, list) {
>  			if (!audit_compare_rule(rule, &e->rule)) {
>  				list_del(&e->list);
> -				call_rcu(&e->rcu, audit_free_rule, e);
> +				write_unlock(&auditsc_lock);
>  				return 0;
>  			}
>  		}
> 
> -- 
> | Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
> | GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
> | http://www.fi.muni.cz/~kas/   Czech Linux Homepage: http://www.linux.cz/ |
> > Whatever the Java applications and desktop dances may lead to, Unix will <
> > still be pushing the packets around for a quite a while.      --Rob Pike <
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 

      reply	other threads:[~2004-11-03 19:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-02 23:23 [PATCH] Minor fix of RCU documentation Jan Kasprzak
2004-11-03 18:59 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041103185954.GA1331@us.ibm.com \
    --to=paulmck@us.ibm.com \
    --cc=kas@fi.muni.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox