From: Christoph Hellwig <hch@lst.de>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] deprecate cli, sti & friends
Date: Wed, 3 Nov 2004 21:35:37 +0100 [thread overview]
Message-ID: <20041103203537.GA25947@lst.de> (raw)
In-Reply-To: <20041103184625.GA24462@lst.de>
On Wed, Nov 03, 2004 at 07:46:25PM +0100, Christoph Hellwig wrote:
> We provided compat wrappers for !CONFIG_SMP builds for ages, but I think
> it's time to get the last folks to notice this can't stay so forever..
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Mitchell Blank Jr found a small typo, so here's a new version:
--------
We provided compat wrappers for !CONFIG_SMP builds for ages, but I think
it's time to get the last folks to notice this can't stay so forever..
Signed-off-by: Christoph Hellwig <hch@lst.de>
--- 1.33/include/linux/interrupt.h 2004-10-28 09:40:01 +02:00
+++ edited/include/linux/interrupt.h 2004-11-03 21:31:02 +01:00
@@ -61,12 +61,30 @@
* Temporary defines for UP kernels, until all code gets fixed.
*/
#ifndef CONFIG_SMP
-# define cli() local_irq_disable()
-# define sti() local_irq_enable()
-# define save_flags(x) local_save_flags(x)
-# define restore_flags(x) local_irq_restore(x)
-# define save_and_cli(x) local_irq_save(x)
-#endif
+static inline void __deprecated cli(void)
+{
+ local_irq_disable();
+}
+static inline void __deprecated sti(void)
+{
+ local_irq_enable();
+}
+static inline void __deprecated save_flags(unsigned long *x)
+{
+ local_save_flags(*x);
+}
+#define save_flags(x) save_flags(&x);
+static inline void __deprecated restore_flags(unsigned long x)
+{
+ local_irq_restore(x);
+}
+
+static inline void __deprecated save_and_cli(unsigned long *x)
+{
+ local_irq_save(*x);
+}
+#define save_and_cli(x) save_and_cli(&x)
+#endif /* CONFIG_SMP */
/* SoftIRQ primitives. */
#define local_bh_disable() \
prev parent reply other threads:[~2004-11-03 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 18:46 [PATCH] deprecate cli, sti & friends Christoph Hellwig
2004-11-03 20:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041103203537.GA25947@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox