public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Michael J. Cohen" <mjc@unre.st>
Cc: "K.R. Foley" <kr@cybsft.com>,
	sboyce@blueyonder.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.7
Date: Thu, 4 Nov 2004 12:45:45 +0100	[thread overview]
Message-ID: <20041104114545.GA3722@elte.hu> (raw)
In-Reply-To: <1099567061.7911.4.camel@localhost>


* Michael J. Cohen <mjc@unre.st> wrote:

> Turned off the debugging stuff to fix this one :/
> 
> might_sleep issue at swap_on and firefox causes oopsen.
> 
> dmesg is 120k+ so here:
> 
> http://325i.org/software/2.6.10-rc1-mm2-RT-V0.7.8.dmesg

does the patch below fix the fbcon problem? (if any new oops happens or
old one triggers again then please re-post the syslog or serial console
capture)

	Ingo

--- linux/drivers/video/console/fbcon.c.orig
+++ linux/drivers/video/console/fbcon.c
@@ -1051,7 +1051,14 @@ static void fbcon_cursor(struct vc_data 
 	struct display *p = &fb_display[vc->vc_num];
 	int y = real_y(p, vc->vc_y);
  	int c = scr_readw((u16 *) vc->vc_pos);
+#ifdef CONFIG_PREEMPT_REALTIME
+	unsigned long flags;
+#endif
 
+#ifdef CONFIG_PREEMPT_REALTIME
+	local_save_flags(flags);
+	local_irq_enable();
+#endif
 	ops->cursor_flash = 1;
 	if (mode & CM_SOFTBACK) {
 		mode &= ~CM_SOFTBACK;
@@ -1069,6 +1076,9 @@ static void fbcon_cursor(struct vc_data 
 	ops->cursor(vc, info, p, mode, get_color(vc, info, c, 1),
 		    get_color(vc, info, c, 0));
 	vbl_cursor_cnt = CURSOR_DRAW_DELAY;
+#ifdef CONFIG_PREEMPT_REALTIME
+	local_irq_restore(flags);
+#endif
 }
 
 static int scrollback_phys_max = 0;

  reply	other threads:[~2004-11-04 12:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-03 17:08 [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.7 Sid Boyce
2004-11-03 18:51 ` K.R. Foley
2004-11-04  0:00   ` Sid Boyce
2004-11-04  1:40     ` K.R. Foley
2004-11-04  9:59       ` Michael J. Cohen
2004-11-04 10:06       ` Ingo Molnar
2004-11-04 10:23         ` Michael J. Cohen
2004-11-04 11:17           ` Ingo Molnar
2004-11-04 11:17           ` Michael J. Cohen
2004-11-04 11:45             ` Ingo Molnar [this message]
2004-11-04 12:59               ` Michael J. Cohen
2004-11-04 13:34                 ` Michael J. Cohen
2004-11-04 14:05                   ` Ingo Molnar
2004-11-04 14:13                     ` Michael J. Cohen
2004-11-04 14:23                       ` Ingo Molnar
2004-11-04 18:31                         ` Michael J. Cohen
2004-11-04 19:38                           ` Ingo Molnar
2004-11-05 12:16                             ` Sid Boyce
2004-11-05 19:53                             ` Michael J. Cohen
2004-11-06  7:36                               ` Ingo Molnar
2004-11-04 12:53         ` Sid Boyce
  -- strict thread matches above, loose matches on Subject: below --
2004-11-03 20:40 [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.1 Mark_H_Johnson
2004-11-04  0:17 ` [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.7 Rui Nuno Capela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041104114545.GA3722@elte.hu \
    --to=mingo@elte.hu \
    --cc=kr@cybsft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjc@unre.st \
    --cc=sboyce@blueyonder.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox