From: Olaf Hering <olh@suse.de>
To: linux-kernel@vger.kernel.org
Subject: fix initcall_debug on ppc64/ia64
Date: Thu, 4 Nov 2004 22:05:47 +0100 [thread overview]
Message-ID: <20041104210547.GA16238@suse.de> (raw)
In-Reply-To: <20041103152628.19753cf2.akpm@osdl.org>
On Wed, Nov 03, Andrew Morton wrote:
> Olaf Hering <olh@suse.de> wrote:
> >
> > Is a patch like that acceptable (for mainline)? Currently only the
> > descriptor is printed, not the function itself. Another redirection is
> > needed.
>
> Is this acked by Paul and Anton? If so, I'll replace __powerpc64__ with
> CONFIG_PPC64 and run with it.
I guess we need something like this.
Just where to put it, how to name it and how to handle ia64:
diff -purNx tags linux-2.6.9/include/linux/kallsyms.h linux-2.6.10-rc1-bk14.initcall_debug/include/linux/kallsyms.h
--- linux-2.6.9/include/linux/kallsyms.h 2004-10-18 23:53:06.000000000 +0200
+++ linux-2.6.10-rc1-bk14.initcall_debug/include/linux/kallsyms.h 2004-11-04 21:37:19.789304911 +0100
@@ -47,6 +47,15 @@ __attribute__((format(printf,1,2)));
static inline void __check_printsym_format(const char *fmt, ...)
{
}
+#ifdef CONFIG_PPC64
+#define print_foo_symbol(fmt, addr) \
+do { \
+ unsigned long *__pfs = (unsigned long*) addr; \
+ print_symbol(fmt, __pfs[0]); \
+} while (0)
+#else
+#define print_foo_symbol(fmt, addr) print_symbol(fmt, addr)
+#endif
#define print_symbol(fmt, addr) \
do { \
diff -purNx tags linux-2.6.9/init/main.c linux-2.6.10-rc1-bk14.initcall_debug/init/main.c
--- linux-2.6.9/init/main.c 2004-11-04 21:01:04.878455673 +0100
+++ linux-2.6.10-rc1-bk14.initcall_debug/init/main.c 2004-11-04 21:08:01.191792667 +0100
@@ -604,7 +604,7 @@ static void __init do_initcalls(void)
if (initcall_debug) {
printk(KERN_DEBUG "Calling initcall 0x%p", *call);
- print_symbol(": %s()", (unsigned long) *call);
+ print_foo_symbol(": %s()", (unsigned long) *call);
printk("\n");
}
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
next parent reply other threads:[~2004-11-04 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041102195130.GA13589@suse.de>
[not found] ` <20041103152628.19753cf2.akpm@osdl.org>
2004-11-04 21:05 ` Olaf Hering [this message]
2004-11-04 23:47 ` fix initcall_debug on ppc64/ia64 Andreas Schwab
2004-11-05 12:49 ` [PATCH] " Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041104210547.GA16238@suse.de \
--to=olh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox