public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-input@atrey.karlin.mff.cuni.cz
Cc: Adrian Bunk <bunk@stusta.de>,
	vojtech@suse.cz, linux-joystick@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] small input cleanup
Date: Sat, 6 Nov 2004 22:49:54 -0500	[thread overview]
Message-ID: <200411062249.54887.dtor_core@ameritech.net> (raw)
In-Reply-To: <20041107031256.GD14308@stusta.de>

Hi,

On Saturday 06 November 2004 10:12 pm, Adrian Bunk wrote:
> The patch below does the following cleanups under drivers/input/ :
> - make some needlessly global code static
> - remove the completely unused EXPORT_SYMBOL'ed function gameport_rescan

It will be used (but in some transformed) once I finish gameport sysfs
support, but it probably need not be exported.
 
> - make the EXPORT_SYMBOL'ed function ps2_sendbyte static since it isn't
>   used outside the file where it's defined

libps2 is a library for communicating with standard PS/2 device and while
the function is not currently used it is part of the interface. I would
like to leave the function as is.

-- 
Dmitry

  reply	other threads:[~2004-11-07  3:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-07  3:12 [2.6 patch] small input cleanup Adrian Bunk
2004-11-07  3:49 ` Dmitry Torokhov [this message]
2004-11-07 17:29   ` Adrian Bunk
2004-11-07 17:47     ` Vojtech Pavlik
2004-11-21 17:48       ` Adrian Bunk
2004-11-21 18:08         ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200411062249.54887.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=bunk@stusta.de \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-joystick@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox