public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] panic_blink and i8042 unloading
Date: Sun, 7 Nov 2004 11:14:35 +0100	[thread overview]
Message-ID: <20041107101435.GA2752@wotan.suse.de> (raw)
In-Reply-To: <200411070134.31775.dtor_core@ameritech.net>

On Sun, Nov 07, 2004 at 01:34:31AM -0500, Dmitry Torokhov wrote:
> Hi,
> 
> At unload i8042 sets panic_blink to 0. This will cause problems if kernel
> panics later as it will just use it assuming that the pointer is correct.
> 
> Please consider the patch below that checks if panic_blink is NULL right
> in panic() and sets it to no_blink instead.

Thanks, looks good.

-Andi

      reply	other threads:[~2004-11-07 10:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-07  6:34 [PATCH] panic_blink and i8042 unloading Dmitry Torokhov
2004-11-07 10:14 ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041107101435.GA2752@wotan.suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox