From: Russell King <rmk+lkml@arm.linux.org.uk>
To: David Brownell <david-b@pacbell.net>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.10-rc1-bk] shrink struct device a bit
Date: Sun, 7 Nov 2004 10:54:47 +0000 [thread overview]
Message-ID: <20041107105447.A27505@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200411041937.31077.david-b@pacbell.net>; from david-b@pacbell.net on Thu, Nov 04, 2004 at 08:37:31PM -0700
On Thu, Nov 04, 2004 at 08:37:31PM -0700, David Brownell wrote:
> Two fields were duplicates of ones in the PM struct,
> and weren't much used in any case.
> +#else /* !CONFIG_PM */
> +#define sa1111_resume 0
> +#define sa1111_suspend 0
...
> +#else
> +#define neponset_suspend 0
> +#define neponset_resume 0
> +#endif
I think sparse will complain at being given '0' instead of 'NULL' for
pointers. Please use NULL instead.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-11-07 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 3:37 [patch 2.6.10-rc1-bk] shrink struct device a bit David Brownell
2004-11-07 10:54 ` Russell King [this message]
2004-11-08 1:52 ` David Brownell
2004-11-12 20:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041107105447.A27505@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox