From: Sergey Vlasov <vsu@altlinux.ru>
To: Jason Baron <jbaron@redhat.com>
Cc: Krzysztof Taraszka <dzimi@pld-linux.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] Add back lost call to tty->driver.set_termios
Date: Sun, 7 Nov 2004 23:13:19 +0300 [thread overview]
Message-ID: <20041107201319.GC2345@sirius.home> (raw)
In-Reply-To: <20041107200601.GA2345@sirius.home>
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
The call to tty->driver.set_termios in change_termios() has been lost;
after termios locking changes it can be put back safely.
--- kernel-source-2.4.27/drivers/char/tty_ioctl.c.set_termios 2004-11-07 18:28:12 +0300
+++ kernel-source-2.4.27/drivers/char/tty_ioctl.c 2004-11-07 21:44:36 +0300
@@ -138,6 +138,9 @@ static void change_termios(struct tty_st
}
}
+ if (tty->driver.set_termios)
+ (*tty->driver.set_termios)(tty, &old_termios);
+
ld = tty_ldisc_ref(tty);
if (ld != NULL) {
if (ld->set_termios)
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-11-07 20:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 17:49 [Patch] 2.4.28-pre3 tty/ldisc fixes Jason Baron
2004-10-28 18:35 ` Sergey Vlasov
2004-10-28 18:42 ` Jason Baron
[not found] ` <Pine.LNX.4.44.0410291426240.13340-200000@dhcp83-105.boston.redhat.com>
2004-10-30 19:19 ` Sergey Vlasov
2004-10-31 9:53 ` Krzysztof Taraszka
2004-11-02 15:02 ` Jason Baron
2004-11-07 20:06 ` Sergey Vlasov
2004-11-07 20:10 ` [PATCH] Update termios to use per tty semaphore (backport from 2.6.x) Sergey Vlasov
2004-11-07 20:13 ` Sergey Vlasov [this message]
2004-10-31 17:18 ` [Patch] 2.4.28-pre3 tty/ldisc fixes Sergey Vlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041107201319.GC2345@sirius.home \
--to=vsu@altlinux.ru \
--cc=dzimi@pld-linux.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox