Re: [2.6 patch] kill IN_STRING_C

[Adrian Bunk <bunk@stusta.de>]

On Mon, Nov 08, 2004 at 06:51:20PM +0100, Andi Kleen wrote:
> On Mon, Nov 08, 2004 at 05:31:01PM +0100, Adrian Bunk wrote:
> > On Mon, Nov 08, 2004 at 05:19:35PM +0100, Andi Kleen wrote:
> > > > Rethinking it, I don't even understand the sprintf example in your 
> > > > changelog entry - shouldn't an inclusion of kernel.h always get it 
> > > > right?
> > > 
> > > Newer gcc rewrites sprintf(buf,"%s",str) to strcpy(buf,str) transparently.
> > 
> > Which gcc is "Newer"?
> 
> I saw it with 3.3-hammer, which had additional optimizations in this 
> area at some point. Note that 3.3-hammer is widely used. I don't 
> know if 3.4 does it in the same way.

Is this a -hammer specific problem?
If yes, does a -no-builtin-sprintf fix it?

Or is the problem a missing #include <linux/kernel.h> at the top of 
include/linux/string.h?

> -Andi

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed