Re: [PATCH] don't divide by 0 when trying to mount ext3

[Rogier Wolff <R.E.Wolff@BitWizard.nl>]

On Mon, Nov 08, 2004 at 10:54:02PM +0100, Andries Brouwer wrote:
> On Mon, Nov 08, 2004 at 10:27:11PM +0100, Rogier Wolff wrote:
> 
> > There are now three cases that end up with the same message and
> > same error from userspace viewpoint. There are many cases where 
> > debugging a problem is helped when it's possible to find out exactly
> > which test determined that the filesystem could not be mounted. 
> 
> Strings are expensive. Don't like to add worthless code.
> We lived without this for years, so it is not a frequent occurrence.
> If you have a bad ext2/ext3 system, e2fsck will find what is wrong.

   int cpos=0;

   if (++cpos && (errorposibility1 ) ) goto error_handling;
[...]
   if (++cpos && (errorposibility2 ) ) goto error_handling;
[...]
   if (++cpos && (errorposibility3 ) ) goto error_handling;
[...]
error_handling:

     printk (".... %d ...", cpos); 

Rogier. 
-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. 
Does it sit on the couch all day? Is it unemployed? Please be specific! 
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ