From: Gerd Knorr <kraxel@bytesex.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: RFC: [2.6 patch] drivers/media/video/ cleanups
Date: Tue, 9 Nov 2004 10:46:48 +0100 [thread overview]
Message-ID: <20041109094648.GB5587@bytesex> (raw)
In-Reply-To: <20041109004341.GO15077@stusta.de>
> OK, the patches follow as followups to this mail.
Thanks, I'll look through that when preparing my next patch set.
Will take some time through as I've just pushed updates and also
will be offline for a week soon.
> > moment automatically is useless. cx88_risc_disasm() for example is
> > useful for debugging the driver. And that there is no in-kernel user
>
> But couldn't this be #if 0'ed?
Yes, it could.
> BTW: Can't lirc be included in the main kernel?
I don't care, the lirc people should, I already have to many projects
for my time.
Last time I checked the code was in a pretty bad state, it needs a
major overhaul IMHO before it can be included. Lots of historical
cruft (dates back to 2.2 days), parts are not SMP save, ...
At least for the TV cards I prefeare to use the linux input layer
instead, see the ir-kbd-* drivers. They didn't catch up yet with
lirc on supported hardware through, so I don't want break lirc now.
But the stuff in bttv-if.c is obsolete and I plan to drop that
altogether some day, see the comment about that in bttv.h. Given that
there will be no 2.7 in near future due to the new devel model I maybe
should make that a time bomb instead ...
Gerd
--
#define printk(args...) fprintf(stderr, ## args)
next prev parent reply other threads:[~2004-11-09 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-07 17:50 RFC: [2.6 patch] drivers/media/video/ cleanups Adrian Bunk
2004-11-08 11:40 ` Gerd Knorr
2004-11-09 0:43 ` Adrian Bunk
2004-11-09 0:50 ` [1/11] drivers/media/video: the easy cleanups Adrian Bunk
2004-11-09 0:51 ` [2/11] media/video/msp3400.c: remove unused struct d1 Adrian Bunk
2004-11-09 0:53 ` [3/11] zoran_driver.c: make zoran_num_formats static Adrian Bunk
2004-11-09 0:55 ` [4/11] bttv-cards.c: remove unused function bttv_reset_audio Adrian Bunk
2004-11-09 0:57 ` [5/11] bttv-risc.c: make some functions static Adrian Bunk
2004-11-09 0:59 ` [6/11] v4l2-common.c: remove v4l2_video_std_fps Adrian Bunk
2004-11-09 1:00 ` [7/11] bttv-driver.c: make some variables static Adrian Bunk
2004-11-09 1:02 ` [8/11] saa7134-core.c: make saa7134_devcount static Adrian Bunk
2004-11-09 1:03 ` [9/11] bttv-i2c.c: make two functions static Adrian Bunk
2004-11-09 1:05 ` [10/11] zoran_device.c: make zr36057_init_vfe static Adrian Bunk
2004-11-09 1:07 ` [11/11] misc bttv statification Adrian Bunk
2004-11-09 9:46 ` Gerd Knorr [this message]
2004-11-10 2:32 ` [2.6 patch] #if 0 cx88_risc_disasm Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041109094648.GB5587@bytesex \
--to=kraxel@bytesex.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox