RE: /sys/devices/system/timer registered twice

Pallipadi, Venkatesh
2004-11-09T23:43:56Z

>-----Original Message-----
>From: linux-kernel-owner@vger.kernel.org
>[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of
>Dmitry Torokhov
>Sent: Tuesday, November 09, 2004 3:19 PM
>To: Greg KH
>Cc: Kay Sievers; linux-kernel@vger.kernel.org
>Subject: Re: /sys/devices/system/timer registered twice
>
>On Tue, 9 Nov 2004 14:52:45 -0800, Greg KH <greg@kroah.com> wrote:
>>
>>
>> On Tue, Nov 09, 2004 at 08:30:43PM +0100, Kay Sievers wrote:
>> > Hi,
>> > I got this on a Centrino box with the latest bk:
>> >
>> > [kay@pim linux.kay]$ ls -l /sys/devices/system/
>> > total 0
>> > drwxr-xr-x 7 root root 0 Nov 8 15:12 .
>> > drwxr-xr-x 5 root root 0 Nov 8 15:12 ..
>> > drwxr-xr-x 3 root root 0 Nov 8 15:12 cpu
>> > drwxr-xr-x 3 root root 0 Nov 8 15:12 i8259
>> > drwxr-xr-x 2 root root 0 Nov 8 15:12 ioapic
>> > drwxr-xr-x 3 root root 0 Nov 8 15:12 irqrouter
>> > ?--------- ? ? ? ? ? timer
>> >
>> >
>> > It is caused by registering two devices with the name "timer" from:
>> >
>> > arch/i386/kernel/time.c
>> > arch/i386/kernel/timers/timer_pit.c
>> >
>> > If I change one of the names, I get two correct looking
>sysfs entries.
>> >
>> > Greg, shouldn't the driver core prevent the corruption of the first
>> > device if another one tries to register with the same name?
>>
>> Hm, this looks like an issue for Dmitry, as there shouldn't be too
>> sysdev_class structures with the same name, right?
>>
>
>I agree, but I think you got the wrong man here ;) You need to talk to
>Venkatesh.
>
>http://linux.bkbits.net:8080/linux-2.5/cset@41810e4aGZ0E5bn_hMb
>4JgIY5u90zA?nav=index.html|src/.|src/arch|src/arch/i386|src/arc
>h/i386/kernel|related/arch/i386/kernel/time.c
>

Yes. It was me :(.

But, do we really need two system devices for timers?. I feel
we can call setup_pit_timer from time.c, whenever pit is being used.
Otherwise, we may have more issues like the order in which these
two resumes are called and the like.

Thanks,
Venki