From: Adrian Bunk <bunk@stusta.de>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] #if 0 cx88_risc_disasm
Date: Wed, 10 Nov 2004 03:32:47 +0100 [thread overview]
Message-ID: <20041110023246.GG4089@stusta.de> (raw)
In-Reply-To: <20041109094648.GB5587@bytesex>
On Tue, Nov 09, 2004 at 10:46:48AM +0100, Gerd Knorr wrote:
>...
> > > moment automatically is useless. cx88_risc_disasm() for example is
> > > useful for debugging the driver. And that there is no in-kernel user
> >
> > But couldn't this be #if 0'ed?
>
> Yes, it could.
>...
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm4-full/drivers/media/video/cx88/cx88-core.c.old 2004-11-10 02:46:36.000000000 +0100
+++ linux-2.6.10-rc1-mm4-full/drivers/media/video/cx88/cx88-core.c 2004-11-10 02:47:15.000000000 +0100
@@ -462,6 +462,7 @@
return incr[risc >> 28] ? incr[risc >> 28] : 1;
}
+#if 0
void cx88_risc_disasm(struct cx88_core *core,
struct btcx_riscmem *risc)
{
@@ -479,6 +480,8 @@
break;
}
}
+EXPORT_SYMBOL(cx88_risc_disasm);
+#endif
void cx88_sram_channel_dump(struct cx88_core *core,
struct sram_channel *ch)
@@ -1197,8 +1200,6 @@
EXPORT_SYMBOL(cx88_risc_stopper);
EXPORT_SYMBOL(cx88_free_buffer);
-EXPORT_SYMBOL(cx88_risc_disasm);
-
EXPORT_SYMBOL(cx88_sram_channels);
EXPORT_SYMBOL(cx88_sram_channel_setup);
EXPORT_SYMBOL(cx88_sram_channel_dump);
next prev parent reply other threads:[~2004-11-10 2:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-07 17:50 RFC: [2.6 patch] drivers/media/video/ cleanups Adrian Bunk
2004-11-08 11:40 ` Gerd Knorr
2004-11-09 0:43 ` Adrian Bunk
2004-11-09 0:50 ` [1/11] drivers/media/video: the easy cleanups Adrian Bunk
2004-11-09 0:51 ` [2/11] media/video/msp3400.c: remove unused struct d1 Adrian Bunk
2004-11-09 0:53 ` [3/11] zoran_driver.c: make zoran_num_formats static Adrian Bunk
2004-11-09 0:55 ` [4/11] bttv-cards.c: remove unused function bttv_reset_audio Adrian Bunk
2004-11-09 0:57 ` [5/11] bttv-risc.c: make some functions static Adrian Bunk
2004-11-09 0:59 ` [6/11] v4l2-common.c: remove v4l2_video_std_fps Adrian Bunk
2004-11-09 1:00 ` [7/11] bttv-driver.c: make some variables static Adrian Bunk
2004-11-09 1:02 ` [8/11] saa7134-core.c: make saa7134_devcount static Adrian Bunk
2004-11-09 1:03 ` [9/11] bttv-i2c.c: make two functions static Adrian Bunk
2004-11-09 1:05 ` [10/11] zoran_device.c: make zr36057_init_vfe static Adrian Bunk
2004-11-09 1:07 ` [11/11] misc bttv statification Adrian Bunk
2004-11-09 9:46 ` RFC: [2.6 patch] drivers/media/video/ cleanups Gerd Knorr
2004-11-10 2:32 ` Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-19 4:57 [2.6 patch] #if 0 cx88_risc_disasm Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041110023246.GG4089@stusta.de \
--to=bunk@stusta.de \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox