From: William Lee Irwin III <wli@holomorphy.com>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: Andrew Morton <akpm@digeo.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Broken kunmap calls in rc4-mm1.
Date: Wed, 10 Nov 2004 17:29:19 -0800 [thread overview]
Message-ID: <20041111012919.GD3217@holomorphy.com> (raw)
In-Reply-To: <1100135825.7402.32.camel@desktop.cunninghams>
On Thu, Nov 11, 2004 at 12:17:05PM +1100, Nigel Cunningham wrote:
> That oops in kunmap got me thinking of my recent DEBUG_HIGHMEM
> additions, so I want for a walk through the -mm4 patch, and found plenty
> of instances of people making the same mistake I did... using the struct
> page * in the call to kunmap, rather than the virtual address.
> I guess the best way to handle it is find/notify the respective authors
> of patches in the tree? The problems are in:
> Reiser4 (lots)
> CacheFS (lots)
> afs
> binfmt_elf
> libata_core
> (I'm hoping some of the above people will see this message and save me
> some effort :>)
That only applies to kunmap_atomic(); kunmap()'s argument should be a page.
-- wli
next prev parent reply other threads:[~2004-11-11 1:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 1:17 Broken kunmap calls in rc4-mm1 Nigel Cunningham
2004-11-11 1:29 ` William Lee Irwin III [this message]
2004-11-11 1:42 ` Nigel Cunningham
2004-11-11 2:59 ` Andrew Morton
2004-11-11 7:45 ` Jens Axboe
2004-11-11 7:50 ` Andrew Morton
2004-11-11 19:22 ` Pavel Machek
2004-11-11 1:34 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041111012919.GD3217@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox