From: Andrew Morton <akpm@osdl.org>
To: dhowells@redhat.com
Cc: torvalds@osdl.org, davidm@snapgear.com,
linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH] VM routine fixes
Date: Thu, 11 Nov 2004 14:31:48 -0800 [thread overview]
Message-ID: <20041111143148.76dcaba4.akpm@osdl.org> (raw)
In-Reply-To: <200411081432.iA8EWfmh023432@warthog.cambridge.redhat.com>
dhowells@redhat.com wrote:
>
> The attached patch fixes a number of problems in the VM routines:
>
> (1) Some inline funcs don't compile if CONFIG_MMU is not set.
>
> (2) swapper_pml4 needn't exist if CONFIG_MMU is not set.
>
> (3) __free_pages_ok() doesn't counter set_page_refs() different behaviour if
> CONFIG_MMU is not set.
>
> (4) swsusp.c invokes TLB flushing functions without including the header file
> that declares them.
>
I spy a secret, uncommented, unchangelogged hunk:
> @@ -112,7 +112,9 @@ int shmem_zero_setup(struct vm_area_stru
> if (vma->vm_file)
> fput(vma->vm_file);
> vma->vm_file = file;
> +#ifdef CONFIG_MMU
> vma->vm_ops = &generic_file_vm_ops;
> +#endif
> return 0;
> }
>
What's happening there?
next prev parent reply other threads:[~2004-11-11 22:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-08 14:32 [PATCH] VM routine fixes dhowells
2004-11-09 12:55 ` Christoph Hellwig
2004-11-09 13:53 ` David Howells
2004-11-09 14:01 ` Christoph Hellwig
2004-11-10 13:37 ` David Howells
2004-11-10 19:01 ` Andrew Morton
2004-11-11 1:17 ` David Woodhouse
2004-11-11 2:26 ` Andrew Morton
2004-11-11 11:29 ` David Howells
2004-11-11 11:43 ` Andrew Morton
2004-11-11 12:03 ` David Howells
2004-11-11 22:31 ` Andrew Morton [this message]
2004-11-12 10:33 ` David Howells
2004-11-12 10:38 ` Andrew Morton
2004-11-12 11:05 ` David Howells
2004-11-14 5:07 ` Linus Torvalds
2004-11-15 13:14 ` David Howells
2004-11-15 15:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041111143148.76dcaba4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).