[PATCH] remove if !PARTITION_ADVANCED condition in defaults

[PATCH] remove if !PARTITION_ADVANCED condition in defaults

[Andries.Brouwer]

Many people are being bitten by the fact that if they select
CONFIG_PARTITION_ADVANCED in order to get some additional support,
they suddenly lose support for the MSDOS_PARTITION type.

Moreover, everybody needs MSDOS_PARTITION - also people not on i386,
since it is the type used on smart media and compact flash and
similar cards.

So, the below advises people "Say Y here" for MSDOS_PARTITION,
and does not change the default choices when PARTITION_ADVANCED
is selected.

Andries

diff -uprN -X /linux/dontdiff a/fs/partitions/Kconfig b/fs/partitions/Kconfig
--- a/fs/partitions/Kconfig	2004-08-26 22:05:38.000000000 +0200
+++ b/fs/partitions/Kconfig	2004-11-11 23:53:11.000000000 +0100
@@ -16,31 +16,31 @@ config PARTITION_ADVANCED
 
 config ACORN_PARTITION
 	bool "Acorn partition support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && ARCH_ACORN
+	default y if ARCH_ACORN
 	help
 	  Support hard disks partitioned under Acorn operating systems.
 
 config ACORN_PARTITION_CUMANA
 	bool "Cumana partition support" if PARTITION_ADVANCED && ACORN_PARTITION
-	default y if !PARTITION_ADVANCED && ARCH_ACORN
+	default y if ARCH_ACORN
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using the Cumana interface on Acorn machines.
 
 config ACORN_PARTITION_EESOX
 	bool "EESOX partition support" if PARTITION_ADVANCED && ACORN_PARTITION
-	default y if !PARTITION_ADVANCED && ARCH_ACORN
+	default y if ARCH_ACORN
 
 config ACORN_PARTITION_ICS
 	bool "ICS partition support" if PARTITION_ADVANCED && ACORN_PARTITION
-	default y if !PARTITION_ADVANCED && ARCH_ACORN
+	default y if ARCH_ACORN
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using the ICS interface on Acorn machines.
 
 config ACORN_PARTITION_ADFS
 	bool "Native filecore partition support" if PARTITION_ADVANCED && ACORN_PARTITION
-	default y if !PARTITION_ADVANCED && ARCH_ACORN
+	default y if ARCH_ACORN
 	help
 	  The Acorn Disc Filing System is the standard file system of the
 	  RiscOS operating system which runs on Acorn's ARM-based Risc PC
@@ -49,14 +49,14 @@ config ACORN_PARTITION_ADFS
 
 config ACORN_PARTITION_POWERTEC
 	bool "PowerTec partition support" if PARTITION_ADVANCED && ACORN_PARTITION
-	default y if !PARTITION_ADVANCED && ARCH_ACORN
+	default y if ARCH_ACORN
 	help
 	  Support reading partition tables created on Acorn machines using
 	  the PowerTec SCSI drive.
 
 config ACORN_PARTITION_RISCIX
 	bool "RISCiX partition support" if PARTITION_ADVANCED && ACORN_PARTITION
-	default y if !PARTITION_ADVANCED && ARCH_ACORN
+	default y if ARCH_ACORN
 	help
 	  Once upon a time, there was a native Unix port for the Acorn series
 	  of machines called RISCiX.  If you say 'Y' here, Linux will be able
@@ -64,21 +64,21 @@ config ACORN_PARTITION_RISCIX
 
 config OSF_PARTITION
 	bool "Alpha OSF partition support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && ALPHA
+	default y if ALPHA
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned on an Alpha machine.
 
 config AMIGA_PARTITION
 	bool "Amiga partition table support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && (AMIGA || AFFS_FS=y)
+	default y if (AMIGA || AFFS_FS=y)
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned under AmigaOS.
 
 config ATARI_PARTITION
 	bool "Atari partition table support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && ATARI
+	default y if ATARI
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned under the Atari OS.
@@ -93,17 +93,16 @@ config IBM_PARTITION
 
 config MAC_PARTITION
 	bool "Macintosh partition map support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && MAC
+	default y if MAC
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned on a Macintosh.
 
 config MSDOS_PARTITION
 	bool "PC BIOS (MSDOS partition tables) support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && !AMIGA && !ATARI && !MAC && !SGI_IP22 && !ARM && !SGI_IP27
+	default y
 	help
-	  Say Y here if you would like to use hard disks under Linux which
-	  were partitioned on an x86 PC (not necessarily by DOS).
+	  Say Y here.
 
 config BSD_DISKLABEL
 	bool "BSD disklabel (FreeBSD partition tables) support"
@@ -189,14 +188,14 @@ config LDM_DEBUG
 
 config SGI_PARTITION
 	bool "SGI partition support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && (SGI_IP22 || SGI_IP27)
+	default y if (SGI_IP22 || SGI_IP27)
 	help
 	  Say Y here if you would like to be able to read the hard disk
 	  partition table format used by SGI machines.
 
 config ULTRIX_PARTITION
 	bool "Ultrix partition table support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && DECSTATION
+	default y if DECSTATION
 	help
 	  Say Y here if you would like to be able to read the hard disk
 	  partition table format used by DEC (now Compaq) Ultrix machines.
@@ -204,7 +203,7 @@ config ULTRIX_PARTITION
 
 config SUN_PARTITION
 	bool "Sun partition tables support" if PARTITION_ADVANCED
-	default y if !PARTITION_ADVANCED && (SPARC32 || SPARC64)
+	default y if (SPARC32 || SPARC64)
 	---help---
 	  Like most systems, SunOS uses its own hard disk partition table
 	  format, incompatible with all others. Saying Y here allows you to

Re: [PATCH] remove if !PARTITION_ADVANCED condition in defaults

[Linus Torvalds]

On Fri, 12 Nov 2004 Andries.Brouwer@cwi.nl wrote:
> 
> So, the below advises people "Say Y here" for MSDOS_PARTITION,
> and does not change the default choices when PARTITION_ADVANCED
> is selected.

Actually, we should make MSDOS_PARTITION not ask at all, unless 
CONFIG_EMBEDDED is set. 

That's really what EMBEDDED means: ask about things that no sane person 
would leave out. So how about just changing that "if PARTITION_ADVANCED" 
into "if EMBEDDED" on MSDOS?

That way PARTITION_ADVANCED really _does_ mean "do you want some
additional choices", without implying that MSDOS would be advancedl. I
absolutely agree that everybody (regardless of architecture) wants msdos
partitions, if only because they are the defacto thing for things like
removable camera media etc.

		Linus

Re: [PATCH] remove if !PARTITION_ADVANCED condition in defaults

[Andries Brouwer]

On Thu, Nov 11, 2004 at 03:11:00PM -0800, Linus Torvalds wrote:
> 
> 
> On Fri, 12 Nov 2004 Andries.Brouwer@cwi.nl wrote:
> > 
> > So, the below advises people "Say Y here" for MSDOS_PARTITION,
> > and does not change the default choices when PARTITION_ADVANCED
> > is selected.
> 
> Actually, we should make MSDOS_PARTITION not ask at all, unless 
> CONFIG_EMBEDDED is set. 

I think that is going too far.
It must be possible to deselect it on an old non-i386 machine
without USB, or an old i386 machine with BSD or minix partition
table, or ...

> That way PARTITION_ADVANCED really _does_ mean "do you want some
> additional choices"

That is what it means right now (after my patch).
And one of the additional choices is to deselect MSDOS_PARTITION.

Andries

Re: [PATCH] remove if !PARTITION_ADVANCED condition in defaults

[Kyle Moffett]

On Nov 11, 2004, at 18:11, Linus Torvalds wrote:
> Actually, we should make MSDOS_PARTITION not ask at all, unless
> CONFIG_EMBEDDED is set.

My dual 1GHz G4 isn't an embedded system by any means, but I don't
want to load crappy MSDOS partition drivers into it, it's intended to
have a blazingly fast boot time with minimal extra drivers.

> That's really what EMBEDDED means: ask about things that no sane person
> would leave out. So how about just changing that "if 
> PARTITION_ADVANCED"
> into "if EMBEDDED" on MSDOS?

If you make this specific to x86, that _may_ be OK, but I suspect 
others who
only have only BSD partitioning schemes may object.

Cheers,
Kyle Moffett

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a17 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r  
!y?(-)
------END GEEK CODE BLOCK------

Re: [PATCH] remove if !PARTITION_ADVANCED condition in defaults

[Geert Uytterhoeven]

On Thu, 11 Nov 2004, Kyle Moffett wrote:
> On Nov 11, 2004, at 18:11, Linus Torvalds wrote:
> > That's really what EMBEDDED means: ask about things that no sane person
> > would leave out. So how about just changing that "if PARTITION_ADVANCED"
> > into "if EMBEDDED" on MSDOS?
> 
> If you make this specific to x86, that _may_ be OK, but I suspect others who
> only have only BSD partitioning schemes may object.

Please do at least that! If a (non-ia32) machine doesn't have USB or FireWire,
it usually doesn't need MS-DOS partitioning. This patch makes it impossible for
people to leave out some stuff (BTW not limited to MS-DOS partitioning) they
don't want. I guess Matt will be happy to add the inverse patch to -tiny...

Andries wrote:
> Many people are being bitten by the fact that if they select
> CONFIG_PARTITION_ADVANCED in order to get some additional support,
> they suddenly lose support for the MSDOS_PARTITION type.

Are you sure Kconfig won't keep the old setting of MSDOS_PARTITION?
Ah IC, this is for people who start from a brand new empty config, willing to
solve the Kernel Quest with the 100000 Kconfig questions(TM) :-)

This looks like yet another fix for yet another PEBKAC problem...  Will (or
perhaps this has been done already as well) we hardcode IDE to yes (on ia32)?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] remove if !PARTITION_ADVANCED condition in defaults

[Andries Brouwer]

On Fri, Nov 12, 2004 at 12:50:21PM +0100, Geert Uytterhoeven wrote:

(wild reaction snipped)

Geert, have you tried?
Didnt you discover that the patch is perfect?

I get the impression that your reaction was written without reading
what was changed.

But if anything is wrong, please say explicitly what.

Andries

Re: [PATCH] remove if !PARTITION_ADVANCED condition in defaults

[Geert Uytterhoeven]

On Fri, 12 Nov 2004, Andries Brouwer wrote:
> On Fri, Nov 12, 2004 at 12:50:21PM +0100, Geert Uytterhoeven wrote:
> (wild reaction snipped)
> 
> Geert, have you tried?
> Didnt you discover that the patch is perfect?
> 
> I get the impression that your reaction was written without reading
> what was changed.
> 
> But if anything is wrong, please say explicitly what.

Sorry, I shouldn't do email when I'm ill...

On a second read, it indeed looks perfect. I missed the already existing `if
PARTITION_ADVANCED' at the end of each `bool "..."' line.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds