Re: [Bonding-devel][PATCH]Zero Copy Transmit Support (Update)

Jay Vosburgh
2004-11-12T22:24:54Z

David S. Miller <davem@davemloft.net> wrote:
>That's definitely a good start.
>
>It does need to be fixed to enforce the usual rules about
>illegal combinations. And his code is going to include
>all sorts of weird things like VLAN offload which I wonder
>if works correctly with the current bonding driver? :)

The existing code should handle VLANs correctly, and the patch
excludes the VLAN related bits from the dev->features update.

>The two rules are codified in register_netdevice() as follows:
[...]

Would it be preferrable to duplicate that logic in bonding, or
push it out to an inline or some such?

-J

---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com