From: Greg KH <greg@kroah.com>
To: Gabriel Paubert <paubert@iram.es>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Subject: Re: Recent I2C "dead code removal" breaks pmac sound.
Date: Fri, 12 Nov 2004 13:20:09 -0800 [thread overview]
Message-ID: <20041112212008.GA2256@kroah.com> (raw)
In-Reply-To: <20041112122215.GA19147@iram.es>
On Fri, Nov 12, 2004 at 01:22:15PM +0100, Gabriel Paubert wrote:
> > Put the function back, and change the pmac.h file to delete the #define,
> > and replace the snd_pmac_keywest_write function with a real call to
> > i2c_smbus_write_block_data so things like this don't happen again.
> >
> > Care to write a patch to do this?
>
> It follows, along with an update of the include/linux/i2c.h to only
> declare functions that actually exist, but grepping the whole sound
> subtree shows that at least sound/oss/dmasound/tas_common.h defines
> a few inline functions that call i2c_smbus_write_{byte,block}_data.
>
> It might be reasonable to split it into two ChangeSets, that's
> your call.
>
> Compiled, booted, tested and CC'ed to BenH just in case.
Applied, thanks.
greg k-h
prev parent reply other threads:[~2004-11-12 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 18:09 Recent I2C "dead code removal" breaks pmac sound Gabriel Paubert
2004-11-11 18:22 ` Greg KH
2004-11-12 12:22 ` Gabriel Paubert
2004-11-12 21:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041112212008.GA2256@kroah.com \
--to=greg@kroah.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paubert@iram.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox