From: Matt Mackall <mpm@selenic.com>
To: linux-kernel <linux-kernel@vger.kernel.org>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH] include ordering breaks sysrq on 8250 serial
Date: Fri, 12 Nov 2004 14:27:11 -0800 [thread overview]
Message-ID: <20041112222710.GD8040@waste.org> (raw)
This has been pestering me for a couple days, finally dug into it:
serial_8250.h was including serial_core.h before SUPPORT_SYSRQ was
getting set up. I suspect this problem exists elsewhere. Tested
against latest bk snapshot.
Signed-off-by: Matt Mackall <mpm@selenic.com>
Index: l-bk20/drivers/serial/8250.c
===================================================================
--- l-bk20.orig/drivers/serial/8250.c Fri Nov 12 13:03:25 2004
+++ l-bk20/drivers/serial/8250.c Fri Nov 12 14:19:04 2004
@@ -20,6 +20,11 @@
* membase is an 'ioremapped' cookie.
*/
#include <linux/config.h>
+
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/tty.h>
@@ -37,10 +42,6 @@
#include <asm/io.h>
#include <asm/irq.h>
-#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
#include <linux/serial_core.h>
#include "8250.h"
--
Mathematics is the supreme nostalgia of our time.
next reply other threads:[~2004-11-12 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 22:27 Matt Mackall [this message]
2004-11-12 22:34 ` [PATCH] include ordering breaks sysrq on 8250 serial Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041112222710.GD8040@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox