Re: Linux 2.4.28-rc3

[Marcelo Tosatti <marcelo.tosatti@cyclades.com>]

On Sat, Nov 13, 2004 at 07:27:09PM +0300, Andrey Melnikoff wrote:
> In article <20041112180052.GE23215@logos.cnet> you wrote:
> > Hi,
> 
> > Here goes the third release candidate.
> 
> > It contains a v2.6 backport of the binfmt_elf potential vulnerabilities
> > disclosed this week, an enhanced smbfs client overflow fix, an ACPI update
> > fixing a couple of nasty bugs, a NFS client bugfix and a network update
> > from Davem.
> 
> Any chance to apply this patch before release?
> 
> Prevent NMI oopser kill kernel thread when megearid2 driver wating abort or
> reset command completion. 

Hi Andrey,

I talked to Atul and Arjan about this one - the correct thing to do is to 
replace mdelay() with CPU yielding msleep(). 

We should backport msleep() in 2.4.29-pre1. 


> Signed-off-by: Andrey Melnikov <temnota+kernel@kmv.ru>
> 
> --- linux-2.4.28-rc3/drivers/scsi/megaraid2.c~	Thu Nov 11 19:37:13 2004
> +++ linux-2.4.28-rc3/drivers/scsi/megaraid2.c	Sat Nov 13 19:20:23 2004
> @@ -39,6 +39,7 @@
>  #include <linux/reboot.h>
>  #include <linux/module.h>
>  #include <linux/list.h>
> +#include <linux/nmi.h>
>  
>  #include "sd.h"
>  #include "scsi.h"
> @@ -2820,6 +2821,7 @@
>  
>  		if( iter++ < MBOX_ABORT_SLEEP*1000 ) {
>  			mdelay(1);
> +			touch_nmi_watchdog();
>  		}
>  		else {
>  			printk(KERN_WARNING
> @@ -2900,6 +2902,7 @@
>  
>  		if( iter++ < MBOX_RESET_SLEEP*1000 ) {
>  			mdelay(1);
> +			touch_nmi_watchdog();
>  		}
>  		else {
>  			printk(KERN_WARNING
> 
> 
> -- 
>  Best regards, TEMHOTA-RIPN aka MJA13-RIPE
>  System Administrator. mailto:temnota@kmv.ru