From: Adrian Bunk <bunk@stusta.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6 patch] OSS via82cxxx_audio.c: enable procfs code
Date: Mon, 15 Nov 2004 01:12:03 +0100 [thread overview]
Message-ID: <20041115001203.GX2249@stusta.de> (raw)
In-Reply-To: <4197F2D9.8050409@pobox.com>
On Sun, Nov 14, 2004 at 07:05:45PM -0500, Jeff Garzik wrote:
> Alan Cox wrote:
> >On Sul, 2004-11-14 at 02:24, Adrian Bunk wrote:
> >
> >>The patch below enables the procfs code in sound/oss/via82cxxx_audio.c
> >>if CONFIG_PROC_FS=y.
> >
> >
> >I don't see what needs fixing here. Generally the /proc file shouldnt
> >exist
>
> Existing procfs code in via82cxxx_audio is never enabled, due to removal
> of CONFIG_SOUND_VIA82CXXX_PROCFS:
>
> #if defined(CONFIG_PROC_FS) && \
> defined(CONFIG_SOUND_VIA82CXXX_PROCFS)
> #define VIA_PROC_FS 1
> #endif
>
> However, I don't mind if someone removes the procfs code completely.
How else is this information available?
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-11-15 0:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 2:24 [2.6 patch] OSS via82cxxx_audio.c: enable procfs code Adrian Bunk
2004-11-14 21:42 ` Alan Cox
2004-11-15 0:05 ` Jeff Garzik
2004-11-15 0:12 ` Adrian Bunk [this message]
2004-11-15 0:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041115001203.GX2249@stusta.de \
--to=bunk@stusta.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox