* [2.6 patch] SCSI ncr53c8xx.c: make a variable static
@ 2004-11-15 2:16 Adrian Bunk
2004-11-16 2:34 ` Matthew Wilcox
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2004-11-15 2:16 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, linux-kernel
The patch below makes a needlessly global variable static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/ncr53c8xx.c.old 2004-11-13 22:27:21.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/ncr53c8xx.c 2004-11-13 22:28:07.000000000 +0100
@@ -7738,7 +7738,7 @@
**==========================================================
*/
#ifdef MODULE
-char *ncr53c8xx; /* command line passed by insmod */
+static char *ncr53c8xx; /* command line passed by insmod */
module_param(ncr53c8xx, charp, 0);
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] SCSI ncr53c8xx.c: make a variable static
2004-11-15 2:16 [2.6 patch] SCSI ncr53c8xx.c: make a variable static Adrian Bunk
@ 2004-11-16 2:34 ` Matthew Wilcox
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2004-11-16 2:34 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James.Bottomley, linux-scsi, linux-kernel
On Mon, Nov 15, 2004 at 03:16:12AM +0100, Adrian Bunk wrote:
> The patch below makes a needlessly global variable static.
This needs to be taken care of as part of a module_param conversion.
Something similar to the sym2 conversion, I think ...
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-16 2:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-15 2:16 [2.6 patch] SCSI ncr53c8xx.c: make a variable static Adrian Bunk
2004-11-16 2:34 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox