public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Michael Chan <mchan@broadcom.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
	Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	akpm@osdl.org, greg@kroah.com, "Durairaj,
	Sundarapandian" <sundarapandian.durairaj@intel.com>
Subject: Re: [PATCH] pci-mmconfig fix for 2.6.9
Date: Mon, 15 Nov 2004 01:01:16 -0700	[thread overview]
Message-ID: <20041115080116.GA5793@colo.lackof.org> (raw)
In-Reply-To: <B1508D50A0692F42B217C22C02D849720312DED5@NT-IRVA-0741.brcm.ad.broadcom.com>

On Sun, Nov 14, 2004 at 11:07:13PM -0800, Michael Chan wrote:
> Grant Grundler wrote:
>  
> > There are two tests in arch/i386/pci/mmconfig.c:pci_mmcfg_init() before
> > the raw_pci_ops is set to &pci_mmcfg. Perhaps some additional crude tests
> > could select a different set of pci_raw_ops to deal with posted writes
> > to mmconfig space. Someone more familiar with those chipsets might
> > find a more elegant solution.
> 
> Do you mean something like pci_mmcfg1 for Intel chipsets that implement
> non-posted mmconfig and pci_mmcfg2 for other chipsets that may implement
> posted mmconfig?

Yes.

> pci_mmcfg2's write method will guarantee that the write has reached
> the target before returning. If pci_mmcfg2's write method uses read
> from the target to flush the write, we are back to the original problem
> of out-of-spec read when writing the PMCSR register. If the flush does
> not require reading from the target device, then it's fine.

Yes - agreed.

I do expect chip designers are aware of this problem.
It's not a new problem.
But it's certainly possible some are not. :^(

thanks,
grant

>  
> Michael
> 
> 
>  

  reply	other threads:[~2004-11-15  8:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-15  7:07 [PATCH] pci-mmconfig fix for 2.6.9 Michael Chan
2004-11-15  8:01 ` Grant Grundler [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-11-13 16:22 Michael Chan
2004-11-13 19:46 ` Grant Grundler
2004-11-14  8:58   ` Andi Kleen
2004-11-15  6:00     ` Grant Grundler
2004-11-15  8:33       ` Andi Kleen
2004-11-12 23:56 Michael Chan
2004-11-13  9:22 ` Andi Kleen
2004-11-12 21:49 Michael Chan
2004-11-12 22:31 ` Grant Grundler
2004-11-12 19:23 Michael Chan
2004-11-12 20:55 ` Grant Grundler
2004-11-12 17:52 Michael Chan
2004-11-12 18:35 ` Grant Grundler
2004-11-11 16:33 Nguyen, Tom L
2004-11-10 22:20 long
2004-11-11  1:30 ` Greg KH
2004-11-11  7:57 ` Andi Kleen
2004-11-10 19:38 long
2004-11-10 19:35 ` Greg KH
2004-11-10 17:26 Durairaj, Sundarapandian
2004-11-10 17:35 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041115080116.GA5793@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=mchan@broadcom.com \
    --cc=sundarapandian.durairaj@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox