public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: dhowells@redhat.com, hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Making compound pages mandatory
Date: Tue, 16 Nov 2004 18:28:41 -0800	[thread overview]
Message-ID: <20041116182841.4ff7f2e5.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0411161746110.2222@ppc970.osdl.org>

Linus Torvalds <torvalds@osdl.org> wrote:
>
> 
> 
> On Tue, 16 Nov 2004, David Howells wrote:
> > 
> > Do you have any objection to compound pages being made mandatory, even without
> > HUGETLB support?
> 
> I haven't really looked into it, so I cannot make an informed decision.  
> How big is the overhead? And what's the _point_, since we don't seem to 
> need them normally, but the code is there for people who _do_ need them? 

Yes, it's just the single pointer chase.  Probably that's the common case
now, because everyone will be enabling hugepages on lots of architectures.

But still, the non-compound code is well tested too, and leaving it in
place does make a little microoptimisation available to those who want it,
so I don't see a reason yet to make compound pages compulsory.

So I'd suggest that we make compound pages conditional on a new
CONFIG_COMPOUND_PAGE and make that equal to HUGETLB_PAGE || !MMU.

  reply	other threads:[~2004-11-17  2:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-16 18:48 [RFC] Making compound pages mandatory David Howells
2004-11-16 19:20 ` Andrew Morton
2004-11-16 19:41   ` David Howells
2004-11-17  1:50 ` Linus Torvalds
2004-11-17  2:28   ` Andrew Morton [this message]
2004-11-17  3:13     ` Nick Piggin
2004-11-17  3:22       ` Nick Piggin
2004-11-17  3:37         ` Nick Piggin
2004-11-17  3:42           ` Nick Piggin
2004-11-17  3:14     ` Linus Torvalds
2004-11-17 12:03       ` David Howells
2004-11-17 11:47     ` David Howells
2004-11-17 11:43   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041116182841.4ff7f2e5.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox