From: Jean Delvare <khali@linux-fr.org>
To: "Thomas Leibold" <thomas@plx.com>
Cc: greg@kroah.com, sensors@stimpy.netroedge.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] i2c-nforce2.c add support for nForce3 Pro 150 MCP
Date: Tue, 16 Nov 2004 22:25:06 +0100 [thread overview]
Message-ID: <20041116222506.7c64e122.khali@linux-fr.org> (raw)
In-Reply-To: <36881.192.168.0.19.1100639614.squirrel@192.168.0.12>
(As a side note I applied your 2.4 patch to lm_sensors CVS.)
> This patch applies to linux 2.6.10-RC1. I tried to follow the
> procedures in Documentation/SubmittingPatches and I hope I got
> everything right.
Looks good to me except:
> @@ -53,6 +55,10 @@ MODULE_DESCRIPTION("nForce2 SMBus driver
> #define PCI_DEVICE_ID_NVIDIA_NFORCE2_SMBUS 0x0064
> #endif
>
> +#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE3_SMBUS
> +#define PCI_DEVICE_ID_NVIDIA_NFORCE3_SMBUS 0x00D4
> +#endif
> +
> (...)
> --- linux-2.6.10-rc1/include/linux/pci_ids.h 2004-11-16 10:22:15.000000000 -0800
> +++ patched/include/linux/pci_ids.h 2004-11-16 11:21:28.223690880 -0800
> @@ -1081,6 +1081,7 @@
> #define PCI_DEVICE_ID_NVIDIA_NVENET_8 0x0056
> #define PCI_DEVICE_ID_NVIDIA_NVENET_9 0x0057
> #define PCI_DEVICE_ID_NVIDIA_CK804_AUDIO 0x0059
> +#define PCI_DEVICE_ID_NVIDIA_NFORCE2_SMBUS 0x0064
> #define PCI_DEVICE_ID_NVIDIA_NFORCE2_IDE 0x0065
> #define PCI_DEVICE_ID_NVIDIA_NVENET_2 0x0066
> #define PCI_DEVICE_ID_NVIDIA_MCP2_AUDIO 0x006a
> @@ -1092,6 +1093,7 @@
> #define PCI_DEVICE_ID_NVIDIA_NFORCE3 0x00d1
> #define PCI_DEVICE_ID_NVIDIA_MCP3_AUDIO 0x00da
> #define PCI_DEVICE_ID_NVIDIA_NFORCE3S 0x00e1
> +#define PCI_DEVICE_ID_NVIDIA_NFORCE3_SMBUS 0x00d4
> #define PCI_DEVICE_ID_NVIDIA_NFORCE3_IDE 0x00d5
> #define PCI_DEVICE_ID_NVIDIA_NVENET_3 0x00d6
> #define PCI_DEVICE_ID_NVIDIA_MCP3_AUDIO 0x00da
You're correct that the IDs are better added to pci_ids.h, but then the
ifndef blocks in the driver become useless and can be discarded.
Thanks.
--
Jean Delvare
http://khali.linux-fr.org/
next prev parent reply other threads:[~2004-11-16 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <36129.192.168.0.19.1100598647.squirrel@192.168.0.12>
[not found] ` <hKBrMfMm.1100605629.3776330.khali@gcu.info>
2004-11-16 21:13 ` [PATCH 2.6] i2c-nforce2.c add support for nForce3 Pro 150 MCP Thomas Leibold
2004-11-16 21:25 ` Jean Delvare [this message]
2004-11-18 10:23 ` Thomas Leibold
2004-11-19 17:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116222506.7c64e122.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
--cc=thomas@plx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox