From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: hch@infradead.org, geert@linux-m68k.org, torvalds@osdl.org,
jgarzik@pobox.com, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org
Subject: Re: [PATCH 475] HP300 LANCE
Date: Tue, 16 Nov 2004 23:12:48 -0800 [thread overview]
Message-ID: <20041116231248.5f61e489.akpm@osdl.org> (raw)
In-Reply-To: <20041116084341.GA24484@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
>
> > There's tons of leaks in the hplcance probing code, and it doesn't release
> > he memory region on removal either.
> >
> > Untested patch to fix those issues below:
>
> ping.
The fix needs a fix:
diff -puN drivers/net/hplance.c~hp300-lance-leak-fixes-fix drivers/net/hplance.c
--- 25/drivers/net/hplance.c~hp300-lance-leak-fixes-fix 2004-11-16 23:11:46.546476832 -0800
+++ 25-akpm/drivers/net/hplance.c 2004-11-16 23:12:00.027427416 -0800
@@ -96,7 +96,7 @@ static int __devinit hplance_init_one(st
hplance_init(dev, d);
err = register_netdev(dev);
if (err)
- goto out_free_netdev;
+ goto out_release_mem_region;
dio_set_drvdata(d, dev);
return 0;
_
next prev parent reply other threads:[~2004-11-17 7:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-31 10:03 [PATCH 475] HP300 LANCE Geert Uytterhoeven
2004-10-31 10:14 ` Jeff Garzik
2004-10-31 10:19 ` Andrew Morton
2004-10-31 10:41 ` Jeff Garzik
2004-10-31 10:48 ` Andrew Morton
2004-10-31 10:57 ` Jeff Garzik
2004-10-31 11:09 ` Andrew Morton
2004-10-31 11:44 ` Geert Uytterhoeven
2004-10-31 11:50 ` Herbert Xu
2004-10-31 11:58 ` Jeff Garzik
2004-11-01 14:22 ` Christoph Hellwig
2004-11-16 8:43 ` Christoph Hellwig
2004-11-17 7:12 ` Andrew Morton [this message]
2004-11-21 10:01 ` Geert Uytterhoeven
2004-11-21 11:19 ` Kars de Jong
2004-11-22 0:12 ` Andrew Morton
2004-11-22 0:25 ` Sohail Somani
2004-11-22 10:54 ` Geert Uytterhoeven
2004-11-22 8:26 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2004-11-01 3:46 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116231248.5f61e489.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox