From: Andrew Morton <akpm@osdl.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: kraxel@bytesex.org, jelle@foks.8m.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cx88: fix printk arg. type
Date: Wed, 17 Nov 2004 11:22:05 -0800 [thread overview]
Message-ID: <20041117112205.7272d362.akpm@osdl.org> (raw)
In-Reply-To: <419B8EC0.2070005@osdl.org>
"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
> Gerd Knorr wrote:
> >>- dprintk(0, "ERROR: Firmware size mismatch (have %ld, expected %d)\n",
> >>+ dprintk(0, "ERROR: Firmware size mismatch (have %Zd, expected %d)\n",
> >
> >
> > Thanks, merged to cvs. I like that 'Z'. Or is that just a linux-kernel
> > printk specific thingy? Or is this standardized somewhere? So I could
> > use that in userspace code as well maybe?
>
> Kernel supports/allows 'Z' or 'z'.
> C99 spec defines 'z' only as a size_t format length modifier:
>
> z Specifies that a following d, i, o, u, x, or X conversion
> specifier applies to a size_t or the corresponding signed integer type
> argument; or that a following n conversion specifier applies to a
> pointer to a signed integer type corresponding to size_t argument.
>
> Anyway, I agree with Al. Will you please change it to
> 'z' instead of 'Z'?
gcc-2.95.x generates warnings for `z', but is happy with 'Z'.
But I seem to be the only person who uses 2.95, and I patched my version to
stop that warning anyway, so...
next prev parent reply other threads:[~2004-11-17 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 23:13 [PATCH] cx88: fix printk arg. type Randy.Dunlap
2004-11-17 17:25 ` Gerd Knorr
2004-11-17 17:47 ` Randy.Dunlap
2004-11-17 18:22 ` Gerd Knorr
2004-11-17 19:22 ` Andrew Morton [this message]
2004-11-17 19:12 ` Randy.Dunlap
2004-11-17 17:58 ` Al Viro
2004-11-17 18:21 ` Jelle Foks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041117112205.7272d362.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jelle@foks.8m.com \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox