* [2.6 patch] move EXPORT_SYMBOL(bttv_i2c_call)
@ 2004-11-16 1:18 Adrian Bunk
2004-11-17 17:39 ` Gerd Knorr
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2004-11-16 1:18 UTC (permalink / raw)
To: Gerd Knorr; +Cc: video4linux-list, linux-kernel
The patch below moves the EXPORT_SYMBOL(bttv_i2c_call) to the file where
the actual function is.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm5-full/drivers/media/video/bttv-i2c.c.old 2004-11-16 01:38:11.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/media/video/bttv-i2c.c 2004-11-16 01:38:23.000000000 +0100
@@ -333,6 +333,7 @@
return;
bttv_call_i2c_clients(&bttvs[card], cmd, arg);
}
+EXPORT_SYMBOL(bttv_i2c_call);
static struct i2c_client bttv_i2c_client_template = {
I2C_DEVNAME("bttv internal"),
--- linux-2.6.10-rc1-mm5-full/drivers/media/video/bttv-if.c.old 2004-11-16 01:37:56.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/media/video/bttv-if.c 2004-11-16 01:38:05.000000000 +0100
@@ -41,7 +41,6 @@
EXPORT_SYMBOL(bttv_read_gpio);
EXPORT_SYMBOL(bttv_write_gpio);
EXPORT_SYMBOL(bttv_get_gpio_queue);
-EXPORT_SYMBOL(bttv_i2c_call);
/* ----------------------------------------------------------------------- */
/* Exported functions - for other modules which want to access the */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] move EXPORT_SYMBOL(bttv_i2c_call)
2004-11-16 1:18 [2.6 patch] move EXPORT_SYMBOL(bttv_i2c_call) Adrian Bunk
@ 2004-11-17 17:39 ` Gerd Knorr
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Knorr @ 2004-11-17 17:39 UTC (permalink / raw)
To: Adrian Bunk; +Cc: video4linux-list, linux-kernel
On Tue, Nov 16, 2004 at 02:18:34AM +0100, Adrian Bunk wrote:
> The patch below moves the EXPORT_SYMBOL(bttv_i2c_call) to the file where
> the actual function is.
Should be the other way around: bttv_i2c_call() belongs into bttv-if.c.
Done in cvs.
Gerd
--
#define printk(args...) fprintf(stderr, ## args)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-17 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-16 1:18 [2.6 patch] move EXPORT_SYMBOL(bttv_i2c_call) Adrian Bunk
2004-11-17 17:39 ` Gerd Knorr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).