From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Robert Love <rml@novell.com>
Cc: Christoph Hellwig <hch@infradead.org>,
ttb@tentacle.dhs.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] inotify: vfs_permission was replaced
Date: Wed, 17 Nov 2004 20:19:26 +0000 [thread overview]
Message-ID: <20041117201925.GG26051@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1100719052.4981.4.camel@betsy.boston.ximian.com>
On Wed, Nov 17, 2004 at 02:17:32PM -0500, Robert Love wrote:
> On Wed, 2004-11-17 at 19:18 +0000, Christoph Hellwig wrote:
>
> > No it doesn't. Please try to understand the APIs before you're using them.
> > Just looking at the callers should give you an immediate clue.
>
> Maybe you should look at the code in question. We actually want to
> perform the exact same sort of permission checks that, say, read
> performs.
Maybe you should look at the code in kernel - e.g. aforementioned sys_read().
Or sys_open().
The only fs-independent code that has any business calling that puppy is
permission(9).
next prev parent reply other threads:[~2004-11-18 2:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 16:57 [patch] inotify: make our sysfs files show up Robert Love
2004-11-17 18:02 ` [patch] inotify: vfs_permission was replaced Robert Love
2004-11-17 19:08 ` Christoph Hellwig
2004-11-17 19:10 ` Robert Love
2004-11-17 19:18 ` Christoph Hellwig
2004-11-17 19:17 ` Robert Love
2004-11-17 20:09 ` Mike Waychison
2004-11-17 20:17 ` [patch] inotify: use permission not vfs_permission Robert Love
2004-11-17 20:25 ` Mike Waychison
2004-11-17 20:28 ` Robert Love
2004-11-18 0:59 ` John McCutchan
2004-11-17 20:19 ` Al Viro [this message]
2004-11-17 20:10 ` [patch] inotify: add sysfs store support Robert Love
2004-11-18 1:00 ` John McCutchan
2004-11-18 1:24 ` Robert Love
2004-11-18 19:05 ` [patch] inotify: grab right lock Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041117201925.GG26051@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
--cc=ttb@tentacle.dhs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox