public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tonnerre <tonnerre@thundrix.ch>
To: "Steffen A. Mork" <linux-dev@morknet.de>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au, torvalds@osdl.org
Subject: Re: [PATCH] dss1_divert ISDN module compile fix for kernel 2.6.8.1
Date: Wed, 17 Nov 2004 23:43:15 +0100	[thread overview]
Message-ID: <20041117224315.GA2198@pauli.thundrix.ch> (raw)
In-Reply-To: <419B662D.5020904@morknet.de>

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Salut,

On Wed, Nov 17, 2004 at 03:54:37PM +0100, Steffen A. Mork wrote:
> http://ls7-www.cs.uni-dortmund.de/~mork/dss1_divert.diff

This patch is wrong. You're using a spinlock you declare on the stack 
of a function, so it's completely pointless.

Please look at http://users.thundrix.ch/~tonnerre/kernel/2.6.1-tch1/ 
where I gathered lots of ISDN patches a while ago. It might be a start 
for you.

			    Tonnerre


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2004-11-17 22:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-17 14:54 [PATCH] dss1_divert ISDN module compile fix for kernel 2.6.8.1 Steffen A. Mork
2004-11-17 16:28 ` Bartlomiej Zolnierkiewicz
2004-11-17 16:55   ` Linus Torvalds
2004-11-17 18:52   ` Steffen A. Mork
2004-11-17 20:07     ` Bartlomiej Zolnierkiewicz
2004-11-17 21:14       ` Steffen A. Mork
2004-11-17 16:39 ` Jan Engelhardt
2004-11-17 22:43 ` Tonnerre [this message]
2004-11-18  5:53   ` [PATCH] " Steffen A. Mork
2004-11-18  5:57     ` Tonnerre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041117224315.GA2198@pauli.thundrix.ch \
    --to=tonnerre@thundrix.ch \
    --cc=linux-dev@morknet.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox