From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Ian.Pratt@cl.cam.ac.uk, haveblue@us.ibm.com,
linux-kernel@vger.kernel.org, Keir.Fraser@cl.cam.ac.uk,
Christian.Limpach@cl.cam.ac.uk
Subject: Re: [patch 2] Xen core patch : arch_free_page return value
Date: Thu, 18 Nov 2004 01:54:29 -0500 [thread overview]
Message-ID: <200411180654.iAI6sTQ3008495@ccure.user-mode-linux.org> (raw)
In-Reply-To: Your message of "Wed, 17 Nov 2004 19:09:33 PST." <20041117190933.16e8b8ed.akpm@osdl.org>
akpm@osdl.org said:
> But heck - why bother? The current patch adds just one line of code
> in one place, and the compiler will toss it away anyway for all but
> xen and um.
Agree, but on a conceptual level, this is allowing the arch to swipe pages
arbitrarily out from under the nose of the generic page allocator. Plus, the
code that's being bypassed has to be implemented in some form in the arch.
That's not my concern, or yours, necessarily, but it does suggest that the
interface is being abused.
Jeff
next prev parent reply other threads:[~2004-11-18 4:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 23:48 [patch 2] Xen core patch : arch_free_page return value Ian Pratt
2004-11-18 1:04 ` Dave Hansen
2004-11-18 1:19 ` Ian Pratt
2004-11-18 1:26 ` Dave Hansen
2004-11-18 8:35 ` Keir Fraser
2004-11-18 9:17 ` Andrew Morton
2004-11-18 5:08 ` Jeff Dike
2004-11-18 3:09 ` Andrew Morton
2004-11-18 6:54 ` Jeff Dike [this message]
2004-11-18 4:57 ` Andrew Morton
2004-11-18 8:37 ` Mitchell Blank Jr
-- strict thread matches above, loose matches on Subject: below --
2004-11-18 10:05 Ian Pratt
2004-11-18 10:14 ` Andrew Morton
2004-11-18 10:18 ` Keir Fraser
2004-11-18 12:39 ` William Lee Irwin III
2004-11-18 10:36 ` William Lee Irwin III
2004-11-18 12:51 ` Ian Pratt
2004-11-18 12:57 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411180654.iAI6sTQ3008495@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=Ian.Pratt@cl.cam.ac.uk \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox