From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Ian Pratt <Ian.Pratt@cl.cam.ac.uk>
Cc: linux-kernel@vger.kernel.org, Keir.Fraser@cl.cam.ac.uk,
Christian.Limpach@cl.cam.ac.uk
Subject: Re: [patch 2] Xen core patch : arch_free_page return value
Date: Thu, 18 Nov 2004 00:37:52 -0800 [thread overview]
Message-ID: <20041118083752.GA35159@gaz.sfgoth.com> (raw)
In-Reply-To: <E1CUZXm-00053v-00@mta1.cl.cam.ac.uk>
One tiny suggestion...
Ian Pratt wrote:
> -void arch_free_page(struct page *page, int order)
> +int arch_free_page(struct page *page, int order)
How about just changing that to...
void __arch_free_page(struct page *page, int order)
... and leave the rest of the function alone. Then:
> -extern void arch_free_page(struct page *page, int order);
> +extern int arch_free_page(struct page *page, int order);
Do...
extern void __arch_free_page(struct page *page, int order);
#define arch_free_page(page, order) (__arch_free_page((page), (order)), 0)
That way the compiler can omit the "if(...) return" even on UML
-Mitch
next prev parent reply other threads:[~2004-11-18 8:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 23:48 [patch 2] Xen core patch : arch_free_page return value Ian Pratt
2004-11-18 1:04 ` Dave Hansen
2004-11-18 1:19 ` Ian Pratt
2004-11-18 1:26 ` Dave Hansen
2004-11-18 8:35 ` Keir Fraser
2004-11-18 9:17 ` Andrew Morton
2004-11-18 5:08 ` Jeff Dike
2004-11-18 3:09 ` Andrew Morton
2004-11-18 6:54 ` Jeff Dike
2004-11-18 4:57 ` Andrew Morton
2004-11-18 8:37 ` Mitchell Blank Jr [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-18 10:05 Ian Pratt
2004-11-18 10:14 ` Andrew Morton
2004-11-18 10:18 ` Keir Fraser
2004-11-18 12:39 ` William Lee Irwin III
2004-11-18 10:36 ` William Lee Irwin III
2004-11-18 12:51 ` Ian Pratt
2004-11-18 12:57 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041118083752.GA35159@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=Ian.Pratt@cl.cam.ac.uk \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox