Re: [PATCH] [Request for inclusion] Filesystem in Userspace

Arjan van de Ven
2004-11-16T09:53:19Z

On Tue, 2004-11-16 at 10:40 +0100, Miklos Szeredi wrote:
> > somehow I find dropping the lock and then doing a list_del() without
> > any kind of verification very suspicious.
>
> list_del() is done with the lock held. Look closely.

yes but how do you know the entry is still on the list and valid ?
you dropped the lock. A normal code pattern is that you then HAVE
to revalidate the assumptions which you guard by that lock.
If there are no such assumptions... then you didn't need the lock.