From: Stelian Pop <stelian@popies.net>
To: Christoph Hellwig <hch@infradead.org>,
mdharm-usb@one-eyed-alien.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] usb-storage should enable scsi disk in Kconfig
Date: Fri, 19 Nov 2004 22:39:42 +0100 [thread overview]
Message-ID: <20041119213942.GG2700@deep-space-9.dsnet> (raw)
In-Reply-To: <20041119195736.GA8466@infradead.org>
On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote:
> On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
> > As $subject says, usb-storage storage should automatically enable
> > scsi disk support in Kconfig.
> >
> > Please apply.
>
> No, it shouldn't. There's lots of usb storage devices that don't use
> sd, as there are lots of SPI/FC/etc.. devices.
Indeed, I should have checked more carefully. My bad.
Still, it is not obvious that one should go into a completly different
config section and manually enable sd support, and I have been bitten
by this more than one time.
Maybe we should add, just below the 'USB storage' Kconfig option another
one, let's say 'SCSI disk based USB storage support', which documentation
would talk about 'usb keys, memory stick readers, USB floppy drives etc',
which should just be a dummy option selecting BLK_DEV_SD ?
Or perhaps we should add something along the Debian's dpkg 'suggests' rule
to Kconfig ? :)
Stelian.
--
Stelian Pop <stelian@popies.net>
next prev parent reply other threads:[~2004-11-19 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 19:33 [PATCH] usb-storage should enable scsi disk in Kconfig Stelian Pop
2004-11-19 19:57 ` Christoph Hellwig
2004-11-19 21:39 ` Stelian Pop [this message]
2004-11-19 23:08 ` Matthew Dharm
2004-11-20 23:21 ` Randy.Dunlap
2004-11-22 10:35 ` Stelian Pop
2004-11-22 16:01 ` Randy.Dunlap
2004-11-22 16:30 ` Stelian Pop
2004-11-22 14:52 ` Martin Waitz
2004-11-29 19:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041119213942.GG2700@deep-space-9.dsnet \
--to=stelian@popies.net \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox