* [patch 2/8] pcmcia/yenta_socket: replace schedule_timeout() with msleep()
@ 2004-10-30 22:47 janitor
2004-11-20 9:34 ` Russell King
0 siblings, 1 reply; 2+ messages in thread
From: janitor @ 2004-10-30 22:47 UTC (permalink / raw)
To: rmk+lkml; +Cc: akpm, linux-kernel, janitor, nacc
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.10-rc1-max/drivers/pcmcia/yenta_socket.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/pcmcia/yenta_socket.c~msleep-drivers_net_irda_pcmcia_yenta_socket drivers/pcmcia/yenta_socket.c
--- linux-2.6.10-rc1/drivers/pcmcia/yenta_socket.c~msleep-drivers_net_irda_pcmcia_yenta_socket 2004-10-24 17:04:56.000000000 +0200
+++ linux-2.6.10-rc1-max/drivers/pcmcia/yenta_socket.c 2004-10-24 17:04:56.000000000 +0200
@@ -827,8 +827,7 @@ static int yenta_probe_cb_irq(struct yen
cb_writel(socket, CB_SOCKET_MASK, CB_CSTSMASK);
cb_writel(socket, CB_SOCKET_FORCE, CB_FCARDSTS);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/10);
+ msleep(100);
/* disable interrupts */
cb_writel(socket, CB_SOCKET_MASK, 0);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/8] pcmcia/yenta_socket: replace schedule_timeout() with msleep()
2004-10-30 22:47 [patch 2/8] pcmcia/yenta_socket: replace schedule_timeout() with msleep() janitor
@ 2004-11-20 9:34 ` Russell King
0 siblings, 0 replies; 2+ messages in thread
From: Russell King @ 2004-11-20 9:34 UTC (permalink / raw)
To: janitor; +Cc: akpm, linux-kernel, nacc
On Sun, Oct 31, 2004 at 12:47:02AM +0200, janitor@sternwelten.at wrote:
> Any comments would be appreciated.
Applied, thanks.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-20 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-30 22:47 [patch 2/8] pcmcia/yenta_socket: replace schedule_timeout() with msleep() janitor
2004-11-20 9:34 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox