From: William Lee Irwin III <wli@holomorphy.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.6.10-rc2-mm2: OSS ac97_codec.h: #include pci.h
Date: Sat, 20 Nov 2004 03:45:47 -0800 [thread overview]
Message-ID: <20041120114547.GU2714@holomorphy.com> (raw)
In-Reply-To: <20041120113545.GC2754@stusta.de>
On Thu, Nov 18, 2004 at 04:42:20AM -0800, William Lee Irwin III wrote:
>> +struct pci_dev;
>> extern int ac97_tune_hardware(struct pci_dev *pdev, struct ac97_quirk *quirk, int override);
>>
>> #endif /* _AC97_CODEC_H_ */
On Sat, Nov 20, 2004 at 12:35:45PM +0100, Adrian Bunk wrote:
> Wouldn't it be better to simply #include pci.h?
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Could be; I opted for avoiding header tangling by default, but if most
includers will use pci.h anyway, so be it.
-- wli
next prev parent reply other threads:[~2004-11-20 11:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-18 10:15 2.6.10-rc2-mm2 Andrew Morton
2004-11-18 11:36 ` [patch] 2.6.10-rc2-mm2: ISDN divert_init.c compile error Adrian Bunk
2004-11-18 12:10 ` 2.6.10-rc2-mm2 Hirokazu Takata
2004-11-18 13:20 ` 2.6.10-rc2-mm2 Hirokazu Takata
2004-11-18 12:42 ` 2.6.10-rc2-mm2 William Lee Irwin III
2004-11-20 11:35 ` [patch] 2.6.10-rc2-mm2: OSS ac97_codec.h: #include pci.h Adrian Bunk
2004-11-20 11:45 ` William Lee Irwin III [this message]
2004-11-18 12:45 ` 2.6.10-rc2-mm2 William Lee Irwin III
2004-11-18 13:57 ` 2.6.10-rc2-mm2 William Lee Irwin III
2004-11-18 14:31 ` 2.6.10-rc2-mm2 William Lee Irwin III
2004-11-18 15:41 ` [patch] 2.6.10-rc2-mm2: MTD_XIP dependencies Adrian Bunk
2004-11-18 15:51 ` David Woodhouse
2004-11-18 16:34 ` Nicolas Pitre
2004-11-18 17:02 ` Russell King
2004-11-18 21:32 ` Adrian Bunk
2004-11-18 22:31 ` Nicolas Pitre
2004-11-18 23:25 ` Adrian Bunk
2004-11-19 1:58 ` Nicolas Pitre
2004-11-19 13:35 ` Adrian Bunk
2004-11-19 16:35 ` Nicolas Pitre
2004-11-21 19:56 ` Adrian Bunk
2004-11-22 0:38 ` Nicolas Pitre
2004-11-22 7:38 ` David Woodhouse
2004-11-18 22:51 ` 2.6.10-rc2-mm2 Valdis.Kletnieks
2004-11-19 0:04 ` [patch] 2.6.10-rc2-mm2: `ST_partstat' multiple definition Adrian Bunk
2004-11-20 2:40 ` 2.6.10-rc2-mm2 Lee Revell
2004-11-20 17:24 ` 2.6.10-rc2-mm2 Lee Revell
2004-11-20 18:31 ` 2.6.10-rc2-mm2 William Lee Irwin III
2004-11-20 21:19 ` 2.6.10-rc2-mm2 Christoph Hellwig
2004-11-20 21:29 ` 2.6.10-rc2-mm2 William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041120114547.GU2714@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox