From: Jean Delvare <khali@linux-fr.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.4] I2C updates for 2.4.28 (2/5)
Date: Sat, 20 Nov 2004 13:16:23 +0100 [thread overview]
Message-ID: <20041120131623.3a723334.khali@linux-fr.org> (raw)
In-Reply-To: <20041120125423.42527051.khali@linux-fr.org>
Original report and discussion:
http://archives.andrew.net.au/lm-sensors/msg28053.html
Bottom line:
The real parser in i2c-proc is partly broken, but in a way it will go
unnoticed in most cases (thus unspotted so far). Still worth fixing
IMHO.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
--- linux-2.4.28-pre4/drivers/i2c/i2c-proc.c.orig 2004-10-16 12:44:30.000000000 +0200
+++ linux-2.4.28-pre4/drivers/i2c/i2c-proc.c 2004-10-16 12:46:38.000000000 +0200
@@ -540,7 +540,7 @@
/* Skip everything until we hit whitespace */
while (bufsize &&
!((ret=get_user(nextchar, (char *) buffer))) &&
- isspace((int) nextchar)) {
+ !isspace((int) nextchar)) {
bufsize--;
((char *) buffer)++;
}
--
Jean Delvare
http://khali.linux-fr.org/
next prev parent reply other threads:[~2004-11-20 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-20 11:54 I2C updates for 2.4.28 Jean Delvare
2004-11-20 12:07 ` [PATCH 2.4] I2C updates for 2.4.28 (1/5) Jean Delvare
2004-11-20 12:16 ` Jean Delvare [this message]
2004-11-20 12:26 ` [PATCH 2.4] I2C updates for 2.4.28 (3/5) Jean Delvare
2004-11-20 12:42 ` [PATCH 2.4] I2C updates for 2.4.28 (5/5) Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041120131623.3a723334.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox